Refactor content types - #6553
Merged
Merged
Conversation
|
Size Change: +134 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
⚡️ Lighthouse report for the changes in this PRLighthouse tested 2 URLs Report for Article
Report for Front
|
mxdvl
force-pushed
the
mxdvl/type-elements
branch
from
November 22, 2022 16:33
3636e52 to
998f58a
Compare
mxdvl
marked this pull request as ready for review
November 22, 2022 16:34
mxdvl
force-pushed
the
mxdvl/type-elements
branch
2 times, most recently
from
November 22, 2022 17:41
cde713b to
ef2e74b
Compare
in QuizAtom, infer the type from the lib, which is more explicit about the coupling.
mxdvl
force-pushed
the
mxdvl/type-elements
branch
from
November 22, 2022 17:48
ef2e74b to
a3f95d0
Compare
AshCorr
approved these changes
Nov 24, 2022
JamieB-gu
added a commit
that referenced
this pull request
Jun 2, 2023
Some descriptions have been updated, others deleted: - `content.d.ts` became `content.ts` in #6553, and its functionality has changed over time - `index.d.ts` has different types, and islands have changed - `window-guardian.ts` has different functionality - `ArticleRenderer.tsx` has different functionality - `App.tsx` no longer exists since #4262
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Convert the ambient
content.d.tsto an explicitycontent.tsfrom which types must be imported.Why?
Importing types explicitely is favourable as it makes refactor easier in the future.