Conversation
Some descriptions have been updated, others deleted: - `content.d.ts` became `content.ts` in #6553, and its functionality has changed over time - `index.d.ts` has different types, and islands have changed - `window-guardian.ts` has different functionality - `ArticleRenderer.tsx` has different functionality - `App.tsx` no longer exists since #4262
Contributor
Author
|
Thanks both! Closing in favour of #7849. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The codebase has changed since much of this was written. This updates or removes each of the descriptions to reflect the current codebase.
Alternatively we could delete it altogether, as it may be likely to become outdated again as the codebase changes: #7849.
Changes
Some descriptions have been updated, others deleted:
content.d.tsbecamecontent.tsin Refactorcontenttypes #6553, and its functionality has changed over timeindex.d.tshas different types, and islands have changedwindow-guardian.tshas different functionalityArticleRenderer.tsxhas different functionalityApp.tsxno longer exists since 👋App.tsx#4262