-
Notifications
You must be signed in to change notification settings - Fork 34
Adaptive site: hydrate islands according to their priority #9021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
aa17e15
Hydrate islands according to their priority
sndrs 2bf0fe3
Do actually hydrate islands according to their priority... (#9035)
sndrs f689b80
docs(getPriority): more explicit error message
sndrs 70d3182
push the void to the top level of initHydration
sndrs 632e04a
Merge branch 'main' into oj/adaptive/prioritised-hydration
sndrs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| import type { Priority } from '../../lib/scheduler'; | ||
| import { isValidSchedulerPriority } from '../../lib/scheduler'; | ||
|
|
||
| /** | ||
| * getPriority takes the given html element and returns its priority attribute | ||
| * | ||
| * We expect the element to always be a `gu-*` custom element | ||
| * | ||
| * @param marker : The html element that we want to read the priority attribute from; | ||
| * @returns | ||
| */ | ||
| export const getPriority = (marker: HTMLElement): Priority | undefined => { | ||
| const priority = marker.getAttribute('priority'); | ||
|
|
||
| if (isValidSchedulerPriority(priority)) { | ||
| return priority; | ||
| } | ||
|
|
||
| console.error( | ||
| 'Unable to find valid priority attribute on gu-island', | ||
| marker, | ||
| ); | ||
|
|
||
| return; | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.