Adaptive site: hydrate islands according to their priority - #9021
Merged
Merged
Conversation
sndrs
force-pushed
the
oj/adaptive/island-priorities
branch
from
October 4, 2023 13:34
d284108 to
dadb0eb
Compare
Co-authored-by: Max Duval <max.duval@theguardian.com>
sndrs
force-pushed
the
oj/adaptive/prioritised-hydration
branch
from
October 4, 2023 13:36
a01f881 to
aa17e15
Compare
|
Size Change: 0 B 🆕 Total Size: 0 B |
cemms1
reviewed
Oct 5, 2023
* actually apply priority settings to islands! * dont bind
cemms1
reviewed
Oct 5, 2023
cemms1
approved these changes
Oct 5, 2023
Co-authored-by: Charlotte Emms <43961396+cemms1@users.noreply.github.com>
mxdvl
force-pushed
the
oj/adaptive/prioritised-hydration
branch
from
October 6, 2023 07:39
7216921 to
f689b80
Compare
mxdvl
reviewed
Oct 6, 2023
mxdvl
left a comment
Contributor
There was a problem hiding this comment.
Maybe we should keep the whenVisible and onInteraction callback signatures as they were?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on #8970...
What does this change?
prioritypropWhy?