Skip to content

Do actually hydrate islands according to their priority... - #9035

Merged
mxdvl merged 2 commits into
oj/adaptive/prioritised-hydrationfrom
sndrs/prioritised-hydration
Oct 5, 2023
Merged

mxdvl merged 2 commits into
oj/adaptive/prioritised-hydrationfrom
sndrs/prioritised-hydration

Conversation

@sndrs

@sndrs sndrs commented Oct 5, 2023

Copy link
Copy Markdown
Contributor

actually apply priorities when hydrating islands!

updates #9021

@sndrs
sndrs requested a review from a team October 5, 2023 14:30
@sndrs
sndrs requested a review from a team as a code owner October 5, 2023 14:30
@sndrs sndrs added 📶 Open Journalism run_chromatic Runs chromatic when label is applied labels Oct 5, 2023
@github-actions

github-actions Bot commented Oct 5, 2023 •

Copy link
Copy Markdown

Size Change: 0 B 🆕

Total Size: 0 B

compressed-size-action

@sndrs
sndrs force-pushed the sndrs/prioritised-hydration branch 2 times, most recently from 3b99982 to b5965bc Compare October 5, 2023 15:04

@mxdvl mxdvl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Priority: CRITICAL

Comment thread dotcom-rendering/src/client/islands/initHydration.ts Outdated
@sndrs
sndrs force-pushed the sndrs/prioritised-hydration branch from b5965bc to 83bef58 Compare October 5, 2023 15:21
@mxdvl
mxdvl merged commit 2bf0fe3 into oj/adaptive/prioritised-hydration Oct 5, 2023
@mxdvl
mxdvl deleted the sndrs/prioritised-hydration branch October 5, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants