fix: Tool Settings now hides pause point helper tools#1410
Conversation
Make the pause point helper tools follow the wait-for-pause-point setting so Tool Settings only exposes the user-facing parent command.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
📝 WalkthroughWalkthroughTool settings enablement now routes pause-point auxiliary tool names through a shared mapping policy. The tool registry and tool catalog use that policy to expose only the wait-for-pause-point settings entry, while tests now exercise the behavior with an in-memory port. ChangesPause-point tool settings linkage
Sequence Diagram(s)sequenceDiagram
participant ToolSettingsUseCase
participant ToolSettingsToolLinkPolicy
participant ToolSettingsService
participant UnityCliLoopToolRegistry
ToolSettingsUseCase->>ToolSettingsToolLinkPolicy: GetSettingsToolName(toolName)
ToolSettingsUseCase->>ToolSettingsService: SetToolEnabled(settingsToolName, enabled)
ToolSettingsUseCase->>ToolSettingsToolLinkPolicy: IsToolEnabled(toolName, ToolSettingsService)
ToolSettingsToolLinkPolicy->>ToolSettingsService: IsToolEnabled(settingsToolName)
UnityCliLoopToolRegistry->>ToolSettingsToolLinkPolicy: IsToolEnabled(tool.ToolName, ToolSettingsService)
UnityCliLoopToolRegistry->>ToolSettingsToolLinkPolicy: IsUserFacingToolSettingsTool(tool.ToolName)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
1 issue found across 5 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Keep pause point helper filtering in the registry catalog so the use case only maps descriptions onto already user-facing settings entries.
Summary
User Impact
Changes
Verification