Skip to content

fix: Tool Settings now hides pause point helper tools#1410

Merged
hatayama merged 2 commits into
v3-betafrom
fix/hide-pause-point-auxiliary-tools
Jun 26, 2026
Merged

fix: Tool Settings now hides pause point helper tools#1410
hatayama merged 2 commits into
v3-betafrom
fix/hide-pause-point-auxiliary-tools

Conversation

@hatayama

@hatayama hatayama commented Jun 26, 2026

Copy link
Copy Markdown
Owner

Summary

  • Tool Settings now shows only the user-facing wait-for-pause-point command instead of listing its helper tools separately.
  • Disabling wait-for-pause-point also disables the related pause point helper tools used behind the scenes.

User Impact

  • Users no longer need to manage clear-pause-point, enable-pause-point, or pause-point-status as separate Tool Settings entries.
  • The pause point tools now behave as one grouped capability from the Settings UI, matching how users think about Wait for Pause Point.

Changes

  • Add a Tool Settings link policy that maps pause point helper tools to wait-for-pause-point.
  • Filter pause point helper tools out of the Tool Settings catalog while preserving their runtime registration.
  • Update use case tests to cover the hidden helper tools and parent toggle behavior.

Verification

  • cli/dist/darwin-arm64/uloop compile --project-path <PROJECT_ROOT>
  • cli/dist/darwin-arm64/uloop run-tests --test-mode EditMode --filter-type regex --filter-value ".ToolSettingsUseCaseTests."
  • cli/dist/darwin-arm64/uloop run-tests --test-mode EditMode --filter-type regex --filter-value ".UnityCliLoopToolRegistryTests."

Review in cubic

Make the pause point helper tools follow the wait-for-pause-point setting so Tool Settings only exposes the user-facing parent command.
@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a8ad0d0f-245c-4c04-886a-0ba2e68e4168

📥 Commits

Reviewing files that changed from the base of the PR and between 07b8401 and 81dd6a3.

⛔ Files ignored due to path filters (1)
  • Packages/src/Editor/Domain/ToolSettingsToolLinkPolicy.cs.meta is excluded by none and included by none
📒 Files selected for processing (4)
  • Assets/Tests/Editor/ToolSettingsUseCaseTests.cs
  • Packages/src/Editor/Application/UseCases/ToolSettingsUseCase.cs
  • Packages/src/Editor/Domain/ToolSettingsToolLinkPolicy.cs
  • Packages/src/Editor/Domain/UnityCliLoopToolRegistry.cs

📝 Walkthrough

Walkthrough

Tool settings enablement now routes pause-point auxiliary tool names through a shared mapping policy. The tool registry and tool catalog use that policy to expose only the wait-for-pause-point settings entry, while tests now exercise the behavior with an in-memory port.

Changes

Pause-point tool settings linkage

Layer / File(s) Summary
Pause-point policy
Packages/src/Editor/Domain/ToolSettingsToolLinkPolicy.cs
Adds the pause-point auxiliary tool set, maps those names to the wait-for-pause-point settings entry, and classifies them as non-user-facing tool settings.
Use case and registry routing
Packages/src/Editor/Application/UseCases/ToolSettingsUseCase.cs, Packages/src/Editor/Domain/UnityCliLoopToolRegistry.cs
ToolSettingsUseCase and UnityCliLoopToolRegistry now consult the shared policy for enablement and catalog exposure, and the native tool list now includes wait-for-pause-point instead of pause-point status.
Tests and in-memory port
Assets/Tests/Editor/ToolSettingsUseCaseTests.cs
The tests switch to an in-memory settings port, assert only the wait-for-pause-point command is shown, verify auxiliary pause-point tools share the enabled state, and add the in-memory port double.

Sequence Diagram(s)

sequenceDiagram
  participant ToolSettingsUseCase
  participant ToolSettingsToolLinkPolicy
  participant ToolSettingsService
  participant UnityCliLoopToolRegistry

  ToolSettingsUseCase->>ToolSettingsToolLinkPolicy: GetSettingsToolName(toolName)
  ToolSettingsUseCase->>ToolSettingsService: SetToolEnabled(settingsToolName, enabled)
  ToolSettingsUseCase->>ToolSettingsToolLinkPolicy: IsToolEnabled(toolName, ToolSettingsService)
  ToolSettingsToolLinkPolicy->>ToolSettingsService: IsToolEnabled(settingsToolName)

  UnityCliLoopToolRegistry->>ToolSettingsToolLinkPolicy: IsToolEnabled(tool.ToolName, ToolSettingsService)
  UnityCliLoopToolRegistry->>ToolSettingsToolLinkPolicy: IsUserFacingToolSettingsTool(tool.ToolName)
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: hiding pause point helper tools in Tool Settings.
Description check ✅ Passed The description is directly related and accurately summarizes the implemented Tool Settings behavior changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/hide-pause-point-auxiliary-tools

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 5 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread Packages/src/Editor/Application/UseCases/ToolSettingsUseCase.cs Outdated
Keep pause point helper filtering in the registry catalog so the use case only maps descriptions onto already user-facing settings entries.
@hatayama
hatayama merged commit 7a7057d into v3-beta Jun 26, 2026
10 checks passed
@hatayama
hatayama deleted the fix/hide-pause-point-auxiliary-tools branch June 26, 2026 12:31
@github-actions github-actions Bot mentioned this pull request Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant