Skip to content

fix: Settings no longer shows watch tools as separate toggles#1789

Merged
hatayama merged 1 commit into
v3-betafrom
hide-watch-tools-from-settings
Jul 14, 2026
Merged

fix: Settings no longer shows watch tools as separate toggles#1789
hatayama merged 1 commit into
v3-betafrom
hide-watch-tools-from-settings

Conversation

@hatayama

@hatayama hatayama commented Jul 14, 2026

Copy link
Copy Markdown
Owner

Summary

  • The Settings window's Built-in Tools list no longer shows enable-watch, clear-watch, and get-watch-values as individual checkboxes.
  • The watch tools now follow the pause-point toggle, since they are auxiliary options of the pause-point feature.

User Impact

  • Before: three watch tools appeared as standalone toggles in Settings, even though they only make sense together with pause-point, and they could be enabled/disabled independently of it.
  • After: Settings shows only the pause-point entry for the whole family. Turning pause-point off also disables the watch tools, matching how the other pause-point auxiliary tools already behave.

Changes

  • Added the three watch tool names to PausePointAuxiliaryToolNames in ToolSettingsToolLinkPolicy, which both hides them from the Settings catalog and maps their enabled state to the pause-point settings key.
  • Added tests verifying the watch tools are excluded from the tool catalog and resolve to the pause-point settings key.

Verification

  • uloop compile: 0 errors, 0 warnings
  • uloop run-tests (EditMode, full suite): 2128 tests, 2121 passed, 0 failed, 7 skipped (pre-existing skips)
  • TDD: the two new tests were confirmed failing before the implementation change

Review in cubic

enable-watch, clear-watch, and get-watch-values appeared as individual
checkboxes in the Settings window even though they are auxiliary options
of the pause-point feature. Add them to PausePointAuxiliaryToolNames so
they disappear from the Built-in Tools catalog and follow the pause-point
enable/disable state, matching the existing pause-point auxiliary tools.
@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 86508541-69cf-45fa-a7dc-0b6b862b959e

📥 Commits

Reviewing files that changed from the base of the PR and between b86e50f and 314d5e9.

📒 Files selected for processing (2)
  • Assets/Tests/Editor/ToolSettingsUseCaseTests.cs
  • Packages/src/Editor/Domain/ToolSettingsToolLinkPolicy.cs

📝 Walkthrough

Walkthrough

The tool settings policy now classifies additional watch tools as pause-point auxiliary tools. Editor tests verify their exclusion from the catalog, non-user-facing status, and mapping to pause-point settings.

Changes

Watch tool settings

Layer / File(s) Summary
Pause-point watch mapping
Packages/src/Editor/Domain/ToolSettingsToolLinkPolicy.cs
Additional watch tool and command names are treated as non-user-facing pause-point auxiliary tools and mapped to the pause-point settings name.
Watch tool validation
Assets/Tests/Editor/ToolSettingsUseCaseTests.cs
Tests verify watch auxiliary tools are excluded from the warmed catalog and map correctly through ToolSettingsToolLinkPolicy.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: watch tools are no longer shown as separate Settings toggles.
Description check ✅ Passed The description is directly related to the change and accurately explains the behavior, impact, and verification.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch hide-watch-tools-from-settings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hatayama
hatayama merged commit dad66b7 into v3-beta Jul 14, 2026
10 checks passed
@hatayama
hatayama deleted the hide-watch-tools-from-settings branch July 14, 2026 13:06
@github-actions github-actions Bot mentioned this pull request Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant