fix: Document that --force-recompile is rarely needed in compile skill#1973
Merged
Conversation
Unity already detects and recompiles changed files on a plain `uloop compile`, even when files were edited outside the Editor. Add a "When to use --force-recompile" section explaining why the flag should be avoided (freezes large projects, crosses Domain Reload leaving Success as null, destabilizes the Editor) and the one legitimate exception, mirroring the guidance already present on the v3-beta branch.
Contributor
📝 WalkthroughWalkthroughThe compile skill documentation is synchronized across three locations. Parameter descriptions now require explicit boolean values, and new guidance explains ChangesCompile documentation
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The section repeated the same point in three forms and listed a weak "unstable just-after-reload state" bullet that overlaps with the freeze concern. Keep only the load-bearing facts: Unity detects external edits by itself, a forced recompile can freeze large projects and makes Success come back as null with --wait-for-domain-reload, and the only legitimate use is surfacing warnings hidden by other asmdefs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uloop-compileskill, explaining that the flag is almost never needed since Unity already detects and recompiles changed files on a plainuloop compileSuccesscomes back asnull(unusable for verification), and leaves the Editor in an unstable post-reload statev3-betabranch's compile skillTest plan
.claude/skills,.agents/skills) are byte-identicalSummary
uloop-compile --force-recompile trueshould and should not be used, emphasizing it’s rarely needed because Unity auto-detects changes (including externally edited files) during a standarduloop compile.--force-recompileand--wait-for-domain-reloadrequire explicittrue/falsevalues and do not accept bare flags.--wait-for-domain-reload truecan cause the skill to returnSuccess: null, making the result unusable for verification.v3-beta-mirrored content), verified as byte-identical between source and generated skill docs.