Drop the VERIFY_TOKEN compat alias from sandbox env output - #11
Merged
Conversation
…tput sandbox env now emits WEBHOOK_HMAC_SECRET as the only signing key. The VERIFY_TOKEN alias existed solely so pre-split starter-kits could read the signing secret under the old name; webhook-starter-kit v3 removed that fallback, so the alias has no remaining consumer. channels env is unchanged: real channels still export a genuine VERIFY_TOKEN for the webhook verification GET.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe sandbox ChangesSandbox environment key update
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This was referenced Jul 15, 2026
ord669
added a commit
that referenced
this pull request
Aug 12, 2026
…en-alias Drop the VERIFY_TOKEN compat alias from sandbox env output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hookmyapp sandbox env(text and--json) now emitsWEBHOOK_HMAC_SECRETas the only signing key and no longer duplicates it underVERIFY_TOKEN. The alias existed solely for starter-kits from before the verify-token/HMAC split; webhook-starter-kit v3 (hookmyapp/webhook-starter-kit#3) removed that fallback, so the alias has no remaining consumer. The sandbox tunnel never issues the verify-GET handshake, so nothing in the sandbox flow readsVERIFY_TOKENat all.channels envis unchanged — real channels still export a genuineVERIFY_TOKENfor the one-time webhook verification GET, which is a distinct concept from the HMAC signing secret.Also updates the cross-repo drift test's canonical key list (verified against the merged kit main) and the README sandbox env samples. 920/920 tests, lint and tsc clean.
Tracked as AIT-126 in Linear.
Summary by CodeRabbit
New Features
WEBHOOK_HMAC_SECRETfor webhook signing.Bug Fixes
VERIFY_TOKENentry from generated WhatsApp and Instagram sandbox environment files.