Add channels webhook hmac show (AIT-183) - #24
Merged
Conversation
… surface (AIT-183) channels webhook show no longer receives hmacSecret bundled with verifyToken (backend split). New command reads it from GET /webhook-config/:id/hmac: hookmyapp channels webhook hmac show <channel>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds ChangesWebhook HMAC show
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant CLI
participant runChannelWebhookHmacShow
participant API
participant output
CLI->>runChannelWebhookHmacShow: invoke with channel and JSON option
runChannelWebhookHmacShow->>API: GET /webhook-config/:channelId/hmac
API-->>runChannelWebhookHmacShow: return HMAC secret
runChannelWebhookHmacShow->>output: render secret as a read result
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
ord669
added a commit
that referenced
this pull request
Aug 12, 2026
* feat(channels): add webhook hmac show — HMAC secret gets its own read surface (AIT-183) channels webhook show no longer receives hmacSecret bundled with verifyToken (backend split). New command reads it from GET /webhook-config/:id/hmac: hookmyapp channels webhook hmac show <channel> * test: starter-kit canonical env keys include VERIFY_TOKEN (drift from AIT-179)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hookmyapp channels webhook hmac show <channel>— reads the HMAC signing secret (X-HookMyApp-Signature-256) from the newGET /webhook-config/:channelId/hmacendpointchannels webhook showkeeps webhookUrl + verifyToken only; the two secrets are no longer bundled in one payload (Verify Token ≠ HMAC)hmacgroup +hmac showBackend companion: hookmyapp/hookmyapp#100.
Test plan
hmac showhits/webhook-config/:id/hmac, outputskind: 'read'tsc --noEmitcleanSummary by CodeRabbit
hookmyapp channels webhook hmac show <channel>to display a channel’s webhook HMAC configuration.--jsonsupport for the command output.VERIFY_TOKEN.