Overhaul facial adjacency + boundary tagging - #252
Merged
Conversation
not fully implemented for partition_mesh; need to be able to create multiple nonlocal adjacency groups with distinct transformations
changed from a list of maps to a list of lists to allow multiple adjacency groups per mesh group pair
splits single InterPartitionAdjacencyGroup into one per remote neighbor group for each local mesh group
majosm
force-pushed
the
facial-adj-overhaul
branch
from
July 27, 2021 20:24
7450e0b to
c7a51cb
Compare
Collaborator
Author
|
(Looks like I need to do a little more work on the |
majosm
force-pushed
the
facial-adj-overhaul
branch
5 times, most recently
from
July 29, 2021 21:36
77a0fb9 to
f2b6ac9
Compare
majosm
marked this pull request as ready for review
August 3, 2021 17:14
Collaborator
Author
|
Just looking for a review of the high-level overview in the OP to check if this seems reasonable (though feel free to take a glance through the code if you're feeling particularly adventurous. 🙂) After that I'll split this up into smaller pieces. |
inducer
reviewed
Aug 23, 2021
inducer
reviewed
Aug 23, 2021
majosm
force-pushed
the
facial-adj-overhaul
branch
2 times, most recently
from
August 31, 2021 19:20
fdf3231 to
5732798
Compare
majosm
force-pushed
the
facial-adj-overhaul
branch
4 times, most recently
from
September 16, 2021 21:40
0f75406 to
bdfa920
Compare
majosm
force-pushed
the
facial-adj-overhaul
branch
from
September 16, 2021 21:45
bdfa920 to
9ddcde7
Compare
Collaborator
Author
|
I think this is ready for another look @inducer. |
inducer
reviewed
Sep 20, 2021
doesn't appear to be necessary; don't remember why this was here
…ary_adjacency_groups
majosm
force-pushed
the
facial-adj-overhaul
branch
from
September 21, 2021 19:40
2740f2b to
4c62225
Compare
thomasgibson
left a comment
Collaborator
There was a problem hiding this comment.
Some comments/touch-ups in places after reading through the changes. Thank you for spending the time doing all this!
Co-authored-by: Thomas H. Gibson <gibsonthomas1120@hotmail.com>
Co-authored-by: Thomas H. Gibson <gibsonthomas1120@hotmail.com>
Owner
|
Thanks for working on this, and thanks @thomasgibson for taking a look! |
inducer
enabled auto-merge (rebase)
September 22, 2021 21:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Mesh's facial adjacency structure to allow multiple adjacency groups for each pair of mesh element groups. In other words,List[Dict[FacialAdjacencyGroup]]becomesList[List[FacialAdjacencyGroup]].FacialAdjacencyGroupintoInteriorAdjacencyGroupandBoundaryAdjacencyGroupsubclasses (withInterPartitionAdjacencyGroupinheriting fromBoundaryAdjacencyGroup).boundary_tags/boundary_tag_bitfromMesh.InteriorAdjacencyGroup/InterPartitionAdjacencyGroup.This will almost certainly need to be split into multiple PRs, but I wanted to throw this up here first for CI + discussion.(Probably incomprehensible unless read commit-by-commit.)