Skip to content

CI: Fix working directories to be relative#120

Merged
nathan-weinberg merged 1 commit into
instructlab:mainfrom
danmcp:e2e
Aug 30, 2024
Merged

CI: Fix working directories to be relative#120
nathan-weinberg merged 1 commit into
instructlab:mainfrom
danmcp:e2e

Conversation

@danmcp

@danmcp danmcp commented Aug 30, 2024

Copy link
Copy Markdown
Contributor

This should get PR validation back to a working state. Unfortunately it has to merge before it will take effect.

@mergify mergify Bot added CI/CD Affects CI/CD configuration ci-failure labels Aug 30, 2024
@danmcp danmcp changed the title Fix working directories to be relative CI: Fix working directories to be relative Aug 30, 2024

@nathan-weinberg nathan-weinberg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two nits but otherwise LGTM

Comment thread .github/workflows/e2e-nvidia-t4-x1.yml Outdated
Comment thread .github/workflows/e2e-nvidia-t4-x1.yml Outdated
@mergify mergify Bot added ci-failure and removed ci-failure labels Aug 30, 2024
Signed-off-by: Dan McPherson <dmcphers@redhat.com>
@mergify mergify Bot added ci-failure and removed ci-failure labels Aug 30, 2024
@nathan-weinberg

Copy link
Copy Markdown
Contributor

Merging manually since CI needs this fix to pass

@nathan-weinberg
nathan-weinberg merged commit 2351153 into instructlab:main Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD Affects CI/CD configuration ci-failure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants