Skip to content

CI: Fix working directories to be relative #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nathan-weinberg merged 1 commit into from
Aug 30, 2024
Merged

CI: Fix working directories to be relative #120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .github/workflows/e2e-nvidia-t4-x1.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ jobs:
- name: Fetch and checkout PR
id: fetch_pr
if: github.event_name == 'pull_request_target'
working-directory: ./eval
run: |
git fetch origin pull/${{ github.event.pull_request.number }}/head:pr-${{ github.event.pull_request.number }}
git checkout pr-${{ github.event.pull_request.number }}
Expand All @@ -105,7 +106,7 @@ jobs:
sudo dnf install -y gcc gcc-c++ make git python3.11 python3.11-devel

- name: Install instructlab
working-directory: "${{ env.GITHUB_WORKSPACE }}/instructlab"
working-directory: ./instructlab
run: |
export PATH="/home/ec2-user/.local/bin:/usr/local/cuda/bin:$PATH"
python3.11 -m venv --upgrade-deps venv
Expand All @@ -121,16 +122,17 @@ jobs:
python3.11 -m pip install .[cuda]

- name: Update instructlab-eval library
working-directory: "${{ env.GITHUB_WORKSPACE }}/eval"
working-directory: ./eval
run: |
. "${{ env.GITHUB_WORKSPACE }}/instructlab/venv/bin/activate"
. ../instructlab/venv/bin/activate
pip install .
pip install .[cuda]

- name: Run e2e test
working-directory: ./instructlab
run: |
. venv/bin/activate
./instructlab/scripts/basic-workflow-tests.sh -m
./scripts/basic-workflow-tests.sh -m

stop-runner:
name: Stop external EC2 runner
Expand Down