Skip to content

Regression: rendered bare URLs include trailing ** in Cmd-click target on v0.0.284 #729

Description

@yxlyx

Summary

Regression of #197 / #210 on graff 0.0.284: when an assistant emits a bare URL directly surrounded by Markdown bold delimiters, the closing ** is included in the underlined/clickable URL target.

Cmd-click now activates the link, but it navigates to a malformed URL containing the Markdown delimiters. For a GitHub issue link, GitHub then resolves to an incorrect issues-filter page rather than the issue.

Environment

  • graff: 0.0.284
  • macOS: 26.4.1
  • architecture: arm64
  • observed in the active Codegraff conversation UI

Exact reproduction

Render this assistant output:

**https://github.com/justrach/codegraff/issues/728**

Then hold Cmd and hover over the link, followed by Cmd-click.

Actual behavior

  • Cmd-hover underlines the closing ** as part of the URL.
  • Cmd-click includes the trailing ** in the destination.
  • The malformed GitHub destination ends in 728** rather than 728.
  • In the observed case, GitHub displayed an issues search/filter page with author:728** and the error Invalid value 728** for author, rather than opening issue 728.

The user supplied a screenshot confirming that the trailing asterisks reached GitHub and were interpreted as part of the value.

Expected behavior

  • Markdown emphasis delimiters must never be part of the rendered anchor span or href.
  • Cmd-hover should underline only the URL.
  • Cmd-click should open exactly:
https://github.com/justrach/codegraff/issues/728

Regression context

Issue #197 reported the same trailing-delimiter bug and was closed after #210. A later comment on #197 reported that the problem was still observable through an actual rendered-message path; the requested exact version is now known to be 0.0.284.

The previous fix reportedly covered getChatLinkMatches() and expected Markdown strong parsing to happen before linkification. This reproduction indicates either:

  1. another rendered assistant-message path still receives raw Markdown delimiters, or
  2. the delimiter trimming fix has regressed in the currently shipped UI path.

Required regression test

Please test the final rendered assistant-message anchor, not only the lower-level matcher:

  1. Render **https://github.com/justrach/codegraff/issues/728**.
  2. Assert the visible emphasis is rendered correctly.
  3. Assert the anchor text excludes both delimiter pairs.
  4. Assert the final href is exactly https://github.com/justrach/codegraff/issues/728.
  5. Exercise the actual Cmd-click/open-link path and assert no trailing ** reaches the browser.

No user-specific paths, account identifiers, session IDs, or raw trace data are included in this report.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions