Fix no-color Markdown URL targets (#729) - #731
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #729.
What changed
*,**,_,__,~~, and backticks across arbitrary provider-delta splits./**,/__,/~~, query asterisks, Python double-underscore anchors, and interior**runs.Boundary contract
Markdown wrapper delimiters are presentation syntax and are excluded from the rendered URL. Surrounding brackets and sentence punctuation remain outside GUI link targets. The same characters are preserved byte-for-byte when they are part of an unwrapped URL. Explicit Markdown links continue to use their sanitized destination as the exact
href.Verification
zig build test— 1,913 passed, 1 skippedzig build tui-test— 530 passedpython3 scripts/test-pty-markdown.py zig-out/bin/graff— passed in color and no-color modespython3 scripts/test-tui-stream-markdown.py zig-out/bin/graff— passedbun test— passedbunx tsc --noEmit --pretty false— passedbun run lint— passed