TUI is an in-process ACP client - #653
Closed
justrach wants to merge 3 commits into
Closed
Conversation
graff tui speaks initialize / session/new / prompt / cancel through acp_engine. Thought, tools, and answer text render from session/update the same way Zed and the native app do. No child graff acp — one Agent and the existing ReplCtx turn. Meters, notices, and raw bash stay on tui_sink. ADR 0041.
Zig 0.17 has no std.time.milliTimestamp; graff acp already seeds session ids from the Io clock.
Fold headers classify read_file / bash by name. ACP title is the path or command — that must stay detail, not replace the catalog name.
Owner
Author
|
Already on main (ADR 0041). Closing as superseded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fullscreen pager now speaks the same ACP envelopes as Zed and
apps/native.What changed
graff tui(and TTYgraff repl) is an in-process ACP client:initialize/session/new/session/prompt/session/cancelthroughacp_engine.session/update. Catalog tool names stay on the update (name) so fold headers still say “Read 1 file” / “Running bash…”.graff acp. One Agent, the existingReplCtxturn (replTurnCb).tui_sink(ACP does not name those)./theme,/modelpicker,/rewind, …) stay local./debugprints the ACP session id.ADR 0041.
Not in this slice
/neverstill unknown (ACP advertises it; dispatch does not route it yet).session/request_permissionstill off (--yolo/ unattended).Independent of the v0.0.280 leftover cut.
Tier 1 green locally: 1731 tests (floor 1715), TUI 448, 17 PTY probes.