TUI ACP client + grok-build inset onto release/v0.0.280 - #654
Merged
Conversation
graff tui speaks initialize / session/new / prompt / cancel through acp_engine. Thought, tools, and answer text render from session/update the same way Zed and the native app do. No child graff acp — one Agent and the existing ReplCtx turn. Meters, notices, and raw bash stay on tui_sink. ADR 0041.
Zig 0.17 has no std.time.milliTimestamp; graff acp already seeds session ids from the Io clock.
Fold headers classify read_file / bash by name. ACP title is the path or command — that must stay detail, not replace the catalog name.
Keep ADRs 0037–0040 and the 280 test-root imports; add 0041 / tui_acp.
Copy grok-build's LayoutConfig defaults (outer_hpad 2/2, outer_vpad 1; compact drops to MIN_HPAD 1 and no vpad) so transcript rows, the composer, and the footer sit off the terminal edges.
Horizontal grok-build gutter stays on transcript/composer/footer. Overlay and slash boxes remain edge-to-edge so they still dock on the composer. Settle-tint probes ignore the outer pad; wrap-width hit tests use inner.
The model picker stays a full-width closed box. The composer under it now carries grok-build's 2-cell left gutter, so the dock probe must lstrip before looking for the top rule.
justrach
marked this pull request as ready for review
August 28, 2026 01:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same in-process ACP pager as #653, cherry-picked onto
release/v0.0.280so the leftover cut can take it, plus the grok-build pager inset the TUI was missing.graff tuispeaksinitialize/session/new/session/prompt/session/cancel. Thought, tools, and answer text render fromsession/update. No childgraff acp./tell/peek, schedule idle wake, and the rest of the 280 leftovers stay.Inset (this update). Copied grok-build
LayoutConfigdefaults from xai-org/grok-build (crates/codegen/xai-grok-pager-render/src/appearance/config.rs):outer_hpad_left/right = 2(compact:MIN_HPAD1)outer_vpad = 1(compact: 0) — one blank row between transcript and composerColors stay ours (emerald accent; coral only for errors). No OSC 50.
ADR 0041. Catalog tool names stay on the update so fold headers still say “Read 1 file” / “Running bash…”.
#653 remains the
mainPR. This one is only for the release branch.Tier 1 green: 1753 tests (floor 1745), TUI 459. All 17 PTY probes passed (hover included).