Skip to content

Phase 1: Project Skeleton - #1

Merged
padak merged 1 commit into
mainfrom
phase-1-skeleton
Feb 26, 2026
Merged

Phase 1: Project Skeleton#1
padak merged 1 commit into
mainfrom
phase-1-skeleton

Conversation

@padak

@padak padak commented Feb 26, 2026

Copy link
Copy Markdown
Member

Implementation Summary

Initialize the Python project with uv, create directory structure, Typer CLI skeleton with all command groups, shared models, output formatter, and error handling.

Acceptance Criteria

  • uv pip install -e . succeeds without errors
  • kbagent --help shows app description, lists project, config, context, doctor commands
  • kbagent project --help shows subcommands: add, list, remove, edit, status
  • kbagent config --help shows subcommands: list, detail
  • kbagent --json project list outputs valid JSON
  • kbagent --no-color --help works
  • mask_token() works correctly
  • All Pydantic models can be instantiated and serialized to JSON
  • Project structure matches the plan

Tests

  • tests/test_errors.py - mask_token tests (8 cases), KeboolaApiError tests, ConfigError tests
  • tests/test_models.py - ProjectConfig, AppConfig, ErrorResponse, SuccessResponse serialization/deserialization
  • tests/test_output.py - OutputFormatter JSON mode, human mode, initialization

40 tests, all passing.

Files Changed

  • pyproject.toml
  • .python-version
  • .gitignore
  • README.md
  • uv.lock
  • src/keboola_agent_cli/__init__.py
  • src/keboola_agent_cli/__main__.py
  • src/keboola_agent_cli/cli.py
  • src/keboola_agent_cli/commands/__init__.py
  • src/keboola_agent_cli/commands/project.py
  • src/keboola_agent_cli/commands/config.py
  • src/keboola_agent_cli/commands/context.py
  • src/keboola_agent_cli/commands/doctor.py
  • src/keboola_agent_cli/services/__init__.py
  • src/keboola_agent_cli/models.py
  • src/keboola_agent_cli/config_store.py
  • src/keboola_agent_cli/output.py
  • src/keboola_agent_cli/errors.py
  • tests/__init__.py
  • tests/conftest.py
  • tests/test_errors.py
  • tests/test_models.py
  • tests/test_output.py

@padak @claude
Phase 1: Project skeleton with CLI, models, output formatter, and err…
6c844e5 
…or handling

Initialize the Python project with uv, create directory structure, Typer CLI
skeleton with all command groups (project, config, context, doctor), shared
Pydantic models, OutputFormatter with JSON/Rich dual mode, and error handling
with token masking.

- pyproject.toml with entry point, deps, and dev deps
- Typer root app with --json, --verbose, --no-color global flags
- Project commands: add, list, remove, edit, status (stubs)
- Config commands: list, detail (stubs)
- Context and doctor top-level commands (stubs)
- Pydantic models: AppConfig, ProjectConfig, ErrorResponse, SuccessResponse
- OutputFormatter: JSON mode for agents, Rich mode for humans
- mask_token() helper and KeboolaApiError/ConfigError exceptions
- ConfigStore skeleton with load/save/add/remove/edit/get methods
- Tests: test_errors.py, test_models.py, test_output.py (40 tests, all pass)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@padak
padak merged commit 8b900d9 into main Feb 26, 2026
@padak
padak deleted the phase-1-skeleton branch February 26, 2026 11:53
@padak padak mentioned this pull request Mar 26, 2026
Merged
3 tasks
This was referenced Apr 10, 2026
Merged
Closed
@ottomansky ottomansky mentioned this pull request Apr 22, 2026
Merged
6 tasks
@ottomansky ottomansky mentioned this pull request May 3, 2026
Closed
8 tasks
This was referenced May 24, 2026
Merged
Draft
@padak padak mentioned this pull request Jun 2, 2026
Closed
@ottomansky ottomansky mentioned this pull request Jun 3, 2026
Merged
@padak padak mentioned this pull request Jun 3, 2026
Merged
@padak padak mentioned this pull request Jun 13, 2026
Merged
Matovidlo added a commit that referenced this pull request Jun 15, 2026
@Matovidlo @claude
refactor(release): address review — extract scripts, composite action…
d13d226 
…, dedup

Thermo-nuclear review follow-ups (behavior-preserving):
- #1/#6: move inline nfpm loop -> build/package/linux/build_packages.sh and the
  zip+sha256 -> build/package/zip_binary.sh (explicit per-OS archiver); workflow
  is now pure orchestration.
- #2: .github/actions/setup-build composite (uv + optional Node) replaces the
  repeated setup preamble in pypi/freeze.
- #3: index.sh deb/rpm/apk collapsed into a publish_repo() helper + per-format indexers.
- #5: sign.sh parses the Azure token with jq instead of a sed regex.
- #7: nfpm.yaml notes it's rendered via envsubst.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Matovidlo added a commit that referenced this pull request Jun 17, 2026
@Matovidlo @claude
refactor(release): address review — extract scripts, composite action…
ebac348 
…, dedup

Thermo-nuclear review follow-ups (behavior-preserving):
- #1/#6: move inline nfpm loop -> build/package/linux/build_packages.sh and the
  zip+sha256 -> build/package/zip_binary.sh (explicit per-OS archiver); workflow
  is now pure orchestration.
- #2: .github/actions/setup-build composite (uv + optional Node) replaces the
  repeated setup preamble in pypi/freeze.
- #3: index.sh deb/rpm/apk collapsed into a publish_repo() helper + per-format indexers.
- #5: sign.sh parses the Azure token with jq instead of a sed regex.
- #7: nfpm.yaml notes it's rendered via envsubst.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
martinsifra added a commit that referenced this pull request Aug 26, 2026
@martinsifra @claude
fix(service): apply the PR #703 self-review findings [DMD-1899]
51eaa2c 
The big one (#2, upgraded): the diff sides' wire shape was WRONG in the
implementation and in the test fixtures that defined it. Verified against
connection (ConfigurationVersionResponse + ConfigurationDiffData OA
schemas, now recorded in the notes wire-truth table): each side is
{version, isDeleted, diff: {name, description, changeDescription,
isDisabled, configuration, rows}} -- content NESTED under diff,
version/deletion as side metadata. The classification and both take modes
now read the envelope; the flat-side code would have been dead on arrival
against the live API.

#1: resolve_conflict no longer takes branch_id -- it derives the branch
from the MR itself (branches.branchFromId), so the conflict-set guard and
the branch being written to can never disagree; a caller-supplied id could
point the REPLACing rebase at an unrelated dev branch the guard never
checked. A published/canceled MR (null branchFromId) is refused readably.

#3: take=theirs of a deleted side collapses to the delete resolution,
symmetric with ours ('production deleted it, dev changed it' is a live
conflict shape).
#4: deletion surfaces as top-level ours_deleted/theirs_deleted booleans on
get_config_diff (None = side never existed) -- it is side metadata, not a
content path.
#5: a 'both' row where the sides agree on the identical value carries
agreed: true -- agreement, not a conflict hotspot.
#2 (message half): a take side missing required envelope keys is reported
as a backend contract violation pointing at the resolved-body workaround,
not as caller error.
#6: wire ids compared via _same_id / int-coerced (find_merge_request_for_
branch, merge()'s was_active) -- a string-serialized branchFromId can no
longer silently defeat the post-merge cleanup.
#7: the feature pre-flight raises FeatureNotEnabledError carrying the new
ErrorCode.FEATURE_NOT_ENABLED (value matches the string SearchService
already emits; categorized 'configuration' like PAYG_NOT_AVAILABLE).
#8: ConfigError imported from ..errors like every other service; the
isDefault scan hoisted to services.base.find_default_branch_id and the
copies in config/sync/workspace services migrated (lib.py keeps its own
loop -- the SDK facade does not import the services layer); verify_token
is skipped when the server already serialized viewer (the polyfill's cost
dies with the polyfill); list --state validates against the closed
vocabulary instead of returning a silent count: 0 on a typo.
#9: test imports hoisted (no mid-file noqa), mocks spec'd at the L3 seam
(KeboolaClient + MergeRequests -- a renamed L3 method now fails the tests),
and regression tests added for every finding (82 tests total).

Doc drift: layer2/layer3 references updated to BRANCHES_MERGE_REQUESTS_
FEATURE, the layer3 open nit closed, tokens.py line ref fixed.

Review: tasks/pr-703-review.md (2026-08-27).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@padak