Skip to content

Phase 3: Configuration listing (config service, CLI commands) - #3

Merged
padak merged 1 commit into
mainfrom
phase-3-configs
Feb 26, 2026
Merged

Phase 3: Configuration listing (config service, CLI commands)#3
padak merged 1 commit into
mainfrom
phase-3-configs

Conversation

@padak

@padak padak commented Feb 26, 2026

Copy link
Copy Markdown
Member

Implementation Summary

Implements Phase 3 of the Keboola Agent CLI: multi-project configuration listing and detail retrieval. Adds a full ConfigService business logic layer, replaces config command stubs with real Typer CLI commands, adds Rich table output formatters, and wires everything into the CLI context.

Key changes:

  • config_service.py (NEW): ConfigService with resolve_projects(), list_configs(), get_config_detail() - supports multi-project aggregation with per-project error handling
  • commands/config.py (REPLACED): Full implementation of config list and config detail with filtering, error handling, and dual output modes
  • output.py (EXTENDED): format_configs_table() for Rich tables grouped by project, format_config_detail() for detail panels, warning() method
  • cli.py (EXTENDED): Wire ConfigService into ctx.obj

Acceptance Criteria

  • config list --json returns configs from all projects
  • config list --project X returns configs from one project
  • config list --project X --project Y returns from both
  • config list --component-type extractor filters by type
  • config list --component-id X filters by component
  • config list human mode shows Rich table grouped by project
  • config detail --project X --component-id Y --config-id Z returns detail
  • Partial failure: one project errors, others continue
  • Unknown alias returns exit code 5

Tests

  • uv run pytest tests/ -v - 151 passed (114 existing + 37 new)

New test classes:

  • TestConfigServiceListConfigs (13 tests): multi-project aggregation, type filtering, component_id filtering, partial failure, empty results, unknown alias, client cleanup
  • TestConfigServiceGetConfigDetail (4 tests): success, unknown alias, API error, client cleanup on error
  • TestResolveProjects (4 tests): all projects, specific aliases, unknown alias, empty list
  • TestConfigList (11 tests): JSON output, human output, project filter, multiple projects, type filter, component_id filter, unknown alias exit code 5, partial failure (JSON + human), empty results, invalid component type exit code 2
  • TestConfigDetail (5 tests): JSON output, human output, unknown alias exit code 5, API error exit code, auth error exit code 3

Files Changed

  • src/keboola_agent_cli/services/config_service.py (NEW)
  • src/keboola_agent_cli/commands/config.py (REPLACED stubs)
  • src/keboola_agent_cli/output.py (EXTENDED)
  • src/keboola_agent_cli/cli.py (EXTENDED)
  • tests/test_services.py (EXTENDED)
  • tests/test_cli.py (EXTENDED)

…formatter)

Implement multi-project configuration listing and detail retrieval:

- Add ConfigService with resolve_projects(), list_configs(), get_config_detail()
- Replace config command stubs with full Typer implementation
- Add Rich table formatter grouped by project alias
- Add config detail panel with configuration parameters display
- Wire ConfigService into CLI context
- Per-project errors collected without stopping other projects
- Component type and component ID filtering support
- 37 new tests covering service logic, CLI commands in JSON/human modes,
  partial failures, filtering, and exit codes

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@padak
padak merged commit 0537740 into main Feb 26, 2026
@padak
padak deleted the phase-3-configs branch March 2, 2026 23:05
Matovidlo added a commit that referenced this pull request Jun 15, 2026
…, dedup

Thermo-nuclear review follow-ups (behavior-preserving):
- #1/#6: move inline nfpm loop -> build/package/linux/build_packages.sh and the
  zip+sha256 -> build/package/zip_binary.sh (explicit per-OS archiver); workflow
  is now pure orchestration.
- #2: .github/actions/setup-build composite (uv + optional Node) replaces the
  repeated setup preamble in pypi/freeze.
- #3: index.sh deb/rpm/apk collapsed into a publish_repo() helper + per-format indexers.
- #5: sign.sh parses the Azure token with jq instead of a sed regex.
- #7: nfpm.yaml notes it's rendered via envsubst.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Matovidlo added a commit that referenced this pull request Jun 17, 2026
…, dedup

Thermo-nuclear review follow-ups (behavior-preserving):
- #1/#6: move inline nfpm loop -> build/package/linux/build_packages.sh and the
  zip+sha256 -> build/package/zip_binary.sh (explicit per-OS archiver); workflow
  is now pure orchestration.
- #2: .github/actions/setup-build composite (uv + optional Node) replaces the
  repeated setup preamble in pypi/freeze.
- #3: index.sh deb/rpm/apk collapsed into a publish_repo() helper + per-format indexers.
- #5: sign.sh parses the Azure token with jq instead of a sed regex.
- #7: nfpm.yaml notes it's rendered via envsubst.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
martinsifra added a commit that referenced this pull request Aug 26, 2026
The big one (#2, upgraded): the diff sides' wire shape was WRONG in the
implementation and in the test fixtures that defined it. Verified against
connection (ConfigurationVersionResponse + ConfigurationDiffData OA
schemas, now recorded in the notes wire-truth table): each side is
{version, isDeleted, diff: {name, description, changeDescription,
isDisabled, configuration, rows}} -- content NESTED under diff,
version/deletion as side metadata. The classification and both take modes
now read the envelope; the flat-side code would have been dead on arrival
against the live API.

#1: resolve_conflict no longer takes branch_id -- it derives the branch
from the MR itself (branches.branchFromId), so the conflict-set guard and
the branch being written to can never disagree; a caller-supplied id could
point the REPLACing rebase at an unrelated dev branch the guard never
checked. A published/canceled MR (null branchFromId) is refused readably.

#3: take=theirs of a deleted side collapses to the delete resolution,
symmetric with ours ('production deleted it, dev changed it' is a live
conflict shape).
#4: deletion surfaces as top-level ours_deleted/theirs_deleted booleans on
get_config_diff (None = side never existed) -- it is side metadata, not a
content path.
#5: a 'both' row where the sides agree on the identical value carries
agreed: true -- agreement, not a conflict hotspot.
#2 (message half): a take side missing required envelope keys is reported
as a backend contract violation pointing at the resolved-body workaround,
not as caller error.
#6: wire ids compared via _same_id / int-coerced (find_merge_request_for_
branch, merge()'s was_active) -- a string-serialized branchFromId can no
longer silently defeat the post-merge cleanup.
#7: the feature pre-flight raises FeatureNotEnabledError carrying the new
ErrorCode.FEATURE_NOT_ENABLED (value matches the string SearchService
already emits; categorized 'configuration' like PAYG_NOT_AVAILABLE).
#8: ConfigError imported from ..errors like every other service; the
isDefault scan hoisted to services.base.find_default_branch_id and the
copies in config/sync/workspace services migrated (lib.py keeps its own
loop -- the SDK facade does not import the services layer); verify_token
is skipped when the server already serialized viewer (the polyfill's cost
dies with the polyfill); list --state validates against the closed
vocabulary instead of returning a silent count: 0 on a typo.
#9: test imports hoisted (no mid-file noqa), mocks spec'd at the L3 seam
(KeboolaClient + MergeRequests -- a renamed L3 method now fails the tests),
and regression tests added for every finding (82 tests total).

Doc drift: layer2/layer3 references updated to BRANCHES_MERGE_REQUESTS_
FEATURE, the layer3 open nit closed, tokens.py line ref fixed.

Review: tasks/pr-703-review.md (2026-08-27).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant