Skip to content

TEL-271 Resubscribing to all remote tracks on rejoin - #778

Merged
genseric-ghiro merged 5 commits into
mainfrom
gensericghiro_resubscribing-to-all-remote-tracks-on-rejoin
Aug 7, 2026
Merged

TEL-271 Resubscribing to all remote tracks on rejoin#778
genseric-ghiro merged 5 commits into
mainfrom
gensericghiro_resubscribing-to-all-remote-tracks-on-rejoin

Conversation

@genseric-ghiro

@genseric-ghiro genseric-ghiro commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Sip doesn't handle reconnection with the room properly
  • On resume, nothing to do, same state is kept
  • On rejoin, participant gets a new ID and loses all its subscriptions. However, nothing triggers a re-subscription to remote tracks
  • This PR adds more stats to quantify the reconnections happening
  • It add two new callbacks to handle reconnecting and reconnected events

Test

  • Unit tests
  • Will be tested by simulating a real call as well

@genseric-ghiro genseric-ghiro self-assigned this Aug 6, 2026
@genseric-ghiro
genseric-ghiro requested a review from a team as a code owner August 6, 2026 22:03
devin-ai-integration[bot]

This comment was marked as resolved.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

View 3 additional findings in Devin Review.

Open in Devin Review

Comment thread pkg/sip/room.go
@genseric-ghiro
genseric-ghiro merged commit 3992a99 into main Aug 7, 2026
7 of 8 checks passed
@genseric-ghiro
genseric-ghiro deleted the gensericghiro_resubscribing-to-all-remote-tracks-on-rejoin branch August 7, 2026 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants