Skip to content

TEL-271 Resubscribing to all remote tracks on rejoin #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
genseric-ghiro merged 5 commits into from
Aug 7, 2026
Merged

TEL-271 Resubscribing to all remote tracks on rejoin #778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6c3a5ae
Resubscribing to all remote tracks on rejoin
genseric-ghiro Aug 6, 2026
b9737a6
Making room an atomic field
genseric-ghiro Aug 7, 2026
1a3e331
Tests
genseric-ghiro Aug 7, 2026
db01d2c
nit: making the distinction between reconnections and rejoins clearer
genseric-ghiro Aug 7, 2026
d803ef0
Organizing imports
genseric-ghiro Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions pkg/sip/outbound_utilities_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,8 @@ func newTestRoomWithConfig(log logger.Logger, st *RoomStats, cfg *testRoomConfig
room.roomLog = roomLog

// Create a minimal lksdk.Room without connecting
room.room = lksdk.NewRoom(nil)
sdkRoom := lksdk.NewRoom(nil)
room.room.Store(sdkRoom)

// Set ready immediately (skip connection)
room.ready.Break()
Expand All @@ -150,7 +151,7 @@ func newTestRoomWithConfig(log logger.Logger, st *RoomStats, cfg *testRoomConfig
}
resolve.Resolve()

room.room.OnRoomUpdate(&livekit.Room{ // Set metadata, and specifically Sid
sdkRoom.OnRoomUpdate(&livekit.Room{ // Set metadata, and specifically Sid
Name: "test-room",
Metadata: "test-metadata",
Sid: "test-room-sid",
Expand All @@ -159,12 +160,12 @@ func newTestRoomWithConfig(log logger.Logger, st *RoomStats, cfg *testRoomConfig
})

// Set up minimal participant info
room.p = ParticipantInfo{
room.p.Store(&ParticipantInfo{
ID: "test-participant-id",
RoomName: "test-room",
Identity: "test-participant",
Name: "Test Participant",
}
})

return &testRoom{room: room}
}
Expand All @@ -173,11 +174,11 @@ func newTestRoomWithConfig(log logger.Logger, st *RoomStats, cfg *testRoomConfig
func (r *testRoom) Connect(_ context.Context, conf *config.Config, rconf RoomConfig) error {
// Update participant info from config
partConf := rconf.Participant
r.room.p = ParticipantInfo{
r.room.p.Store(&ParticipantInfo{
RoomName: rconf.RoomName,
Identity: partConf.Identity,
Name: partConf.Name,
}
})
// Skip actual connection - room is already set up
return nil
}
Expand Down
Loading
Loading