Skip to content

fix: resolved merge conflicts by updating link tag with legacy behaviour - #10

Closed
venplane wants to merge 4 commits into
makeplane:stage-releasefrom
venplane:master
Closed

fix: resolved merge conflicts by updating link tag with legacy behaviour#10
venplane wants to merge 4 commits into
makeplane:stage-releasefrom
venplane:master

Conversation

@venplane

Copy link
Copy Markdown
Contributor

refactor:

  • nextjs and dependencies versions upgrade

fix:

  • resolved merge conflicts by updating link tag with legacy behaviour

@vercel

vercel Bot commented Nov 25, 2022

Copy link
Copy Markdown

@venkatesh-soulpage is attempting to deploy a commit to the Caravel Team on Vercel.

A member of the Team first needs to authorize it.

@venplane
venplane changed the base branch from master to stage-release November 25, 2022 19:54
@vihar vihar closed this Nov 29, 2022
dvdcastro added a commit to dvdcastro/plane that referenced this pull request Mar 27, 2026
DRF auto-generates the write field for the state FK as 'state', not
'state_id'.  Clients that follow REST convention and send state_id had
their update silently ignored.

Add an explicit write-only state_id PrimaryKeyRelatedField (source='state')
so both forms are accepted.  The serializer's existing validate() block
already checks that the resolved State belongs to the project, so no
additional validation is needed.

Closes makeplane#10 (188e4144-20a4-4ad9-89de-014b82fdb2ff)
blitzy Bot pushed a commit to Blitzy-Sandbox/blitzy-makeplane that referenced this pull request May 25, 2026
…SDoc

Resolves CP1 QA findings 1-15 (CRITICAL hallucinations) + 16 (MINOR markdown bold):

Critical cross-reference accuracy fixes:
- Issue #1: ce/store/issue/issue-details/activity.store.ts (was core/)
- Issue #2: ce/components/command-palette/ (was core/) — 6 sites
- Issue makeplane#3-4: dashboard/dashboards/** paths replaced with actual
  consumer paths (analytics, helpers/dashboard.helper.ts, home/widgets)
  or INTENT UNCLEAR for orphaned constants — 16 sites
- Issue makeplane#5: description editor paths point to actual locations
- Issue makeplane#6: workspace/billing/ (was workspace-billing/) — 5 sites
- Issue makeplane#7: inbox/modals/create-modal/ (was intake/) — 1 site
- Issue makeplane#8: workspace-notifications/ (was notifications/) — 8 sites
- Issue makeplane#9: removed duplicate fabricated profile/settings/ path — 2 sites
- Issue makeplane#10: project-states/ (was states/) — 4 sites
- Issue makeplane#11: workspace/views/ (was workspace-views/) — 1 site
- Issue makeplane#12: INTENT UNCLEAR for EAuthenticationPageType and
  USER_ALLOWED_PERMISSIONS (no consumers found) — 2 sites
- Issue makeplane#13: issues/issue-layouts/filters/ (was issues/filters/) — 8 sites
- Issue makeplane#14: db/models/integration/ (was app/views/integration/) — 1 site
- Issue makeplane#15: removed hallucinated ::ProjectLink Django class symbol;
  added INTENT UNCLEAR flag for missing backend mirror — 1 site

Documentation standards fix (MINOR):
- Issue makeplane#16: removed 7 instances of markdown bold (**...**) in JSDoc
  per AAP §0.2.3 (no markdown boilerplate)

Per AAP §0.2.3 ambiguity protocol ("Flag, do not invent"), unverifiable
consumer locations are flagged with INTENT UNCLEAR rather than guessed.

Validation: zero new TS errors (Gate 3 PASS); zero new lint/format
violations; no imports/exports changed; no behavior changes — JSDoc-only
edits in 22 files across packages/types/src/ and packages/constants/src/.
ColeEdanza added a commit to ColeEdanza/plane that referenced this pull request May 26, 2026
…lapse, footer, sidebar groups

Five compound UI changes implementing the Plane.so blog redesign (items makeplane#2,
makeplane#3, makeplane#5, makeplane#6, makeplane#7; makeplane#1/makeplane#4/makeplane#8/makeplane#9/makeplane#10/makeplane#11 out of scope per Cole).

- Compact parent pill next to the work-item ID (new IssueParentPill in
  parent/pill.tsx); fat parent breadcrumb row above the title removed in
  both the full-screen page and all peek modes.
- Inline properties row under the title: Assignee, Priority, Start, Due as
  borderless pills with vertical dividers (border-strong), text-body-sm font,
  gap-x-5 spacing, hover background via transparent-with-text variant. State
  stays in the peek header from prior commit 03d84b1.
- DescriptionCollapse wrapper around the rich-text editor: clamps to ~200px
  via ResizeObserver, fade gradient when collapsed, auto-expands on focus,
  Show more / Show less toggle. Wraps both surfaces.
- IssueMetadataFooter at the bottom of main content: created-by, created,
  updated, and completed (when set) in a compact row with full-timestamp
  hover tooltips.
- Sidebar regrouped into three collapsible sections (Properties / Project
  structure / Custom properties). Assignee, Priority, Start, Due removed
  from the sidebar since they're inline now. Parent stays as the only way
  to *add* a parent when none is set.

Title bumped from text-20 to text-28 font-semibold leading-snug py-1; the
prior leading-tight clipped ascenders inside the auto-resize textarea.

Touches:
  apps/web/core/components/issues/issue-detail/main-content.tsx
  apps/web/core/components/issues/issue-detail/sidebar.tsx
  apps/web/core/components/issues/issue-detail/parent/index.ts
  apps/web/core/components/issues/peek-overview/issue-detail.tsx
  + 4 new files:
    parent/pill.tsx, inline-properties.tsx,
    description-collapse.tsx, metadata-footer.tsx

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
SeanFXM added a commit to SeanFXM/HTJPplane that referenced this pull request Jun 14, 2026
makeplane#10 project-wrapper: the PROJECT_MODULES SWR key now includes the route, so
navigating INTO /modules switches keys and triggers the full module fetch.
Previously the key was fixed and revalidateIfStale=false, so a project first
opened on a non-modules route cached the slim-only result and /modules could
render incomplete data until a hard reload.

makeplane#12 i18n: add the 173 (ja) / 185 (zh-CN) translation keys that existed in en
but were missing — they were silently falling back to English (mostly the
power_k command palette, plus settings/profile/members strings). Verified via
script: full parity with en, zero existing values mutated, files formatted with
the project's oxfmt. A native review of the command-palette wording is advisable.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants