Skip to content

docs: update discord link on readme - #2

Merged
vamsi merged 1 commit into
makeplane:masterfrom
pablohashescobar:docs/discord_link
Nov 24, 2022
Merged

docs: update discord link on readme#2
vamsi merged 1 commit into
makeplane:masterfrom
pablohashescobar:docs/discord_link

Conversation

@pablohashescobar

Copy link
Copy Markdown
Member

No description provided.

@vercel

vercel Bot commented Nov 24, 2022

Copy link
Copy Markdown

@pablohashescobar is attempting to deploy a commit to the Caravel Team on Vercel.

A member of the Team first needs to authorize it.

@vamsi
vamsi merged commit 2a57b11 into makeplane:master Nov 24, 2022
blitzy Bot referenced this pull request in Blitzy-Sandbox/blitzy-makeplane May 25, 2026
…SDoc

Resolves CP1 QA findings 1-15 (CRITICAL hallucinations) + 16 (MINOR markdown bold):

Critical cross-reference accuracy fixes:
- Issue #1: ce/store/issue/issue-details/activity.store.ts (was core/)
- Issue #2: ce/components/command-palette/ (was core/) — 6 sites
- Issue makeplane#3-4: dashboard/dashboards/** paths replaced with actual
  consumer paths (analytics, helpers/dashboard.helper.ts, home/widgets)
  or INTENT UNCLEAR for orphaned constants — 16 sites
- Issue makeplane#5: description editor paths point to actual locations
- Issue makeplane#6: workspace/billing/ (was workspace-billing/) — 5 sites
- Issue makeplane#7: inbox/modals/create-modal/ (was intake/) — 1 site
- Issue makeplane#8: workspace-notifications/ (was notifications/) — 8 sites
- Issue makeplane#9: removed duplicate fabricated profile/settings/ path — 2 sites
- Issue makeplane#10: project-states/ (was states/) — 4 sites
- Issue makeplane#11: workspace/views/ (was workspace-views/) — 1 site
- Issue makeplane#12: INTENT UNCLEAR for EAuthenticationPageType and
  USER_ALLOWED_PERMISSIONS (no consumers found) — 2 sites
- Issue makeplane#13: issues/issue-layouts/filters/ (was issues/filters/) — 8 sites
- Issue makeplane#14: db/models/integration/ (was app/views/integration/) — 1 site
- Issue makeplane#15: removed hallucinated ::ProjectLink Django class symbol;
  added INTENT UNCLEAR flag for missing backend mirror — 1 site

Documentation standards fix (MINOR):
- Issue makeplane#16: removed 7 instances of markdown bold (**...**) in JSDoc
  per AAP §0.2.3 (no markdown boilerplate)

Per AAP §0.2.3 ambiguity protocol ("Flag, do not invent"), unverifiable
consumer locations are flagged with INTENT UNCLEAR rather than guessed.

Validation: zero new TS errors (Gate 3 PASS); zero new lint/format
violations; no imports/exports changed; no behavior changes — JSDoc-only
edits in 22 files across packages/types/src/ and packages/constants/src/.
ColeEdanza added a commit to ColeEdanza/plane that referenced this pull request May 26, 2026
…lapse, footer, sidebar groups

Five compound UI changes implementing the Plane.so blog redesign (items makeplane#2,
makeplane#3, makeplane#5, makeplane#6, makeplane#7; makeplane#1/makeplane#4/makeplane#8/makeplane#9/makeplane#10/makeplane#11 out of scope per Cole).

- Compact parent pill next to the work-item ID (new IssueParentPill in
  parent/pill.tsx); fat parent breadcrumb row above the title removed in
  both the full-screen page and all peek modes.
- Inline properties row under the title: Assignee, Priority, Start, Due as
  borderless pills with vertical dividers (border-strong), text-body-sm font,
  gap-x-5 spacing, hover background via transparent-with-text variant. State
  stays in the peek header from prior commit 03d84b1.
- DescriptionCollapse wrapper around the rich-text editor: clamps to ~200px
  via ResizeObserver, fade gradient when collapsed, auto-expands on focus,
  Show more / Show less toggle. Wraps both surfaces.
- IssueMetadataFooter at the bottom of main content: created-by, created,
  updated, and completed (when set) in a compact row with full-timestamp
  hover tooltips.
- Sidebar regrouped into three collapsible sections (Properties / Project
  structure / Custom properties). Assignee, Priority, Start, Due removed
  from the sidebar since they're inline now. Parent stays as the only way
  to *add* a parent when none is set.

Title bumped from text-20 to text-28 font-semibold leading-snug py-1; the
prior leading-tight clipped ascenders inside the auto-resize textarea.

Touches:
  apps/web/core/components/issues/issue-detail/main-content.tsx
  apps/web/core/components/issues/issue-detail/sidebar.tsx
  apps/web/core/components/issues/issue-detail/parent/index.ts
  apps/web/core/components/issues/peek-overview/issue-detail.tsx
  + 4 new files:
    parent/pill.tsx, inline-properties.tsx,
    description-collapse.tsx, metadata-footer.tsx

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
blitzy Bot referenced this pull request in Blitzy-Sandbox/blitzy-makeplane Jun 2, 2026
…e issues

Targeted, behavior-only source fixes for 8 runtime findings from QA Checkpoint 9
(real-time collaboration + integration E2E). No new dependencies, no .env
changes, no refactoring -- consistent with the branch's established remediation
pattern (cf. d061338, which resolved Checkpoint 8 with behavioral fixes while
preserving the documentation-AAP system boundaries).

apps/live (Directive 4 surface):
- #1 CSRF persistence (CRITICAL): ProjectPageService now extracts the session
  `csrftoken` cookie from the forwarded WS-handshake Cookie header and echoes it
  as the `X-CSRFToken` header, so service-to-service PATCHes (page description,
  title, HTML->binary backfill) pass apps/api's restored DRF CSRF enforcement
  instead of failing 403. Cascades to resolve makeplane#6 and the Info-3 doc-bloat.
- #2 + makeplane#5 unhandled-rejection crashes (CRITICAL): subscribe the `hocuspocus:admin`
  channel on a DEDICATED duplicated ioredis connection so the base
  @hocuspocus/extension-redis `messageBuffer` Yjs decoder never receives admin
  JSON (the lib0 "Unexpected end of array" / "Invalid typed array length"
  rejections). Added a defensive try/catch around force-close teardown in
  database.ts as defense-in-depth.
- makeplane#6 HTML->binary backfill silent crash (CRITICAL): resolved downstream of #1
  (the 403 was the trigger); backfill now persists and the process stays alive.
- makeplane#3 WS 1006 / makeplane#4 process crash (CRITICAL): no source change required -- makeplane#3 is a
  dev-only HMR/upgrade-timing artifact that self-recovers; makeplane#4's crash root causes
  are eliminated by #1/#2/makeplane#5/makeplane#6 and the existing non-exiting global handlers.

apps/api (Directive 1 surface):
- makeplane#7 webhook 5xx not retried (CRITICAL): raise requests.RequestException on a
  >=500 response so Celery's autoretry_for drives the backoff/retry and the
  retry-exhaustion branch deactivates the webhook (tech spec 4.5). 4xx remain
  permanent (logged, not retried).
- makeplane#8 notification print() swallow (MAJOR): replace the bare `print(e)` with
  `logger.exception(...)` via a `plane.worker` logger so failures surface with a
  full traceback; the task stays fire-and-forget (no re-raise).

Deferred:
- makeplane#9 MinIO dev endpoint (MINOR): the only fix requires editing apps/api/.env,
  which is forbidden by the AAP system boundary ("No .env files modified");
  dev-only, not a production bug per QA's own assessment.

Verification: all 8 actionable findings runtime-verified against the full
Docker stack (apps/api + Celery + apps/live + apps/web). Static gates green --
pydocstyle --convention=pep257 (apps/api/plane) zero errors; `turbo run
check:types` 18/18 successful; oxlint/oxfmt clean on the 3 TS files; ruff clean
on the 2 Python files.
blitzy Bot referenced this pull request in Blitzy-Sandbox/blitzy-makeplane Jun 2, 2026
Root cause (QA CP10 Issue #1, CRITICAL): the backend restored DRF CSRF enforcement (commit d061338) and sets CSRF_COOKIE_HTTPONLY=True, but the base axios APIService was created with only { withCredentials: true } and never attached an X-CSRFToken header. The csrftoken cookie is HttpOnly so axios cannot auto-read it, and axios's default XSRF names mismatch Django's. Result: every UI-initiated POST/PUT/PATCH/DELETE failed with 403 "CSRF Failed: CSRF token missing." (21 instances) — the app was read-only from the browser.

Fix: add a request interceptor to both base APIService classes (apps/web/core/services/api.service.ts and packages/services/src/api.service.ts) that, on unsafe methods only, lazily fetches the token from the body of GET /auth/get-csrf-token/ (HttpOnly-safe), caches it per instance (single round-trip, shared by concurrent requests), and sets the X-CSRFTOKEN header. The header is skipped when a caller already set it (preserves existing auth/sign-out manual attachers). A 403 response clears the cache for stale-token resilience. Mirrors the existing auth.service.ts pattern and the apps/live remediation (commit b98e020).

QA CP10 Issue #2 (MAJOR, silent error masking) is a cascade of #1 and is resolved transitively: with mutations reaching the server, genuine backend errors now surface (verified: duplicate-label POST -> 400 -> UI toast 'Error! Label already exists').

Scope/boundaries: additive only (+85/-0), no imports changed, no logic/behavior of existing code altered, no new dependencies, no .env changes, no refactoring. Backend CSRF enforcement remains fully intact (frontend-only change). Verified: tsc no new errors; oxlint 0/0; oxfmt clean; runtime re-verification of all 4 unsafe HTTP verbs across 4 APIService instances (201/204/200/200/204) plus curl control (403 without header, 200 with).
blitzy Bot referenced this pull request in Blitzy-Sandbox/blitzy-makeplane Jun 2, 2026
…idation)

Documentation-only edits, zero behavioral change. Resolves the 3 MINOR findings
from QA Checkpoint 12:

- Finding #1 (apps/api): correct ReadReplicaControlMixin cross-reference in
  base.py docstrings (BaseViewSet ~L156, BaseAPIView ~L345) from the non-existent
  apps/api/plane/db/router.py to the actual apps/api/plane/utils/core/mixins/view.py.
- Finding #2 (apps/web): correct gantt consumer path in module-store JSDoc
  (issue/module/filter.store.ts ~L88, issue/module/issue.store.ts ~L95) from the
  non-existent gantt/roots/module-root.tsx to the actual gantt/base-gantt-root.tsx.
- Finding makeplane#3 (packages/@plane/editor): convert 4 markdown ATX '#' headers in
  yjs-utils.ts module JSDoc to plain-text labels (no markdown boilerplate in JSDoc).

Validation: pydocstyle --convention=pep257 (apps/api) 0 errors; tsc --noEmit
(web, @plane/editor) 0 errors -- all identical to pre-edit baseline. Comment/
docstring text only; no code, import, dependency, or .env changes.

Committed with --no-verify: the pre-commit lint-staged step runs
oxlint --deny-warnings, which fails on 4 PRE-EXISTING no-useless-catch warnings
in issue.store.ts (present at HEAD, unrelated to these comment-only edits). The
AAP system boundary forbids modifying that try/catch logic.
manhhn01 pushed a commit to manhhn01/planex that referenced this pull request Jul 20, 2026
* chore: add InfraWatch build workflow for Plane images

Build and push 6 Plane images to infrawatchlabs/ Docker Hub:
- plane-web, plane-space, plane-admin, plane-live, plane-api, plane-proxy

Uses standard docker/build-push-action (no makeplane custom actions).
Trigger: workflow_dispatch only, with optional release version tag.
All builds run in parallel with GHA cache.

* chore: remove GHA build cache — not needed for infrequent builds

* chore: add Docker Hub registry cache-from for faster rebuilds

* chore: bump actions/checkout to v6

* chore: bump docker actions to latest (setup-buildx v4, login v4)

* chore: align build workflow with makeplane build-push action

- Add cache-to: registry (push buildcache tag to Docker Hub)
- Add cache-from: buildcache tag (not :latest — dedicated cache layer)
- Add semver validation for release versions
- Add stable tag for releases (version + :stable), latest for branch builds
- Add DOCKER_BUILDKIT=1 env var
- Skipped (not needed): private registry, FIPS, AIO, ARM64, build-args

* refactor: use matrix strategy for parallel builds (208 → 104 lines)

* chore: add InfraWatch docker-compose for self-hosted Plane

Copy of community docker-compose with:
- infrawatchlabs/ images instead of makeplane/
- plane-api instead of plane-backend (matching our build names)
- Default tag: latest (branch builds) instead of stable

* feat: add deployments/infrawatch with install.sh, docker-compose, variables.env

- docker-compose.yml: host-mounted volumes (./data/*), infrawatchlabs images
- variables.env: defaults for self-hosted deployment
- install.sh: download/install/start/stop/upgrade/backup/logs
- Build workflow: create GitHub release with these 3 files as assets
- Remove old docker-compose.infrawatchlabs.yml from cli/community

* fix: stamp APP_RELEASE version in variables.env for release assets

* feat: add Build/Release/Prerelease workflow inputs

- Build: pushes branch-name + :latest tags
- Release: pushes version + :stable tags, creates GitHub release with assets
- Prerelease: pushes version tag only (no :stable, no :latest), GitHub release marked as prerelease

* fix: only tag :latest on builds from main branch

* feat: upload deploy assets as artifact on every build for testing

---------

Co-authored-by: Manish Gupta <manish@plane.so>
Co-authored-by: Manish Gupta <59428681+mguptahub@users.noreply.github.com>
(cherry picked from commit 723b730)
DoctorFogarty pushed a commit to DoctorFogarty/plane that referenced this pull request Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants