Conversation
Make RCB DataSet detection evidence-driven, pin the corrected ARIEC61850 engine, prevent stale/unknown bindings from becoming false NoDataSet, detect verified source/live binding conflicts, disambiguate duplicate RCB names by logical scope, and add E016-style regression coverage.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9ba78773f6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ied.PrimarySntpServer, | ||
| ied.RedundantSntpServer, | ||
| ied.TimeSyncScopeResult, | ||
| ied.ComtradeApplicability, | ||
| ied.ComtradeScopeResult, |
There was a problem hiding this comment.
Extend the snapshot DTOs beyond these five scope fields to include DocumentControl, PanelTag, and the new per-point traceability fields such as EventLogSearchReference, SourceIecReference, and ReportDisplayReference. After the initial autosave, reopening the same workbook restores this incomplete snapshot instead of the freshly imported project, so regenerated customer reports lose document/panel identity and ReportIecReference falls back to ObjectReference; portable .arsas continuations suffer the same metadata loss.
Useful? React with 👍 / 👎.
|
Superseded by focused PR #138, which was rebuilt cleanly from current |
Fix MMS discovery pagination integration, preserve live signal bindings for 192.168.81.17, use the latest relay fascia artwork, import Rev4 IED_Scope metadata (primary/redundant SNTP, time sync and COMTRADE applicability), and add controlled relay procedures. ARSAS test suite: 130 passed. Final Windows package rebuilt from this commit.