Fix RCB DataSet evidence merge and logical-scope display - #135
Merged
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 12063be1fd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
masarray
added a commit
that referenced
this pull request
Aug 12, 2026
Make RCB DataSet detection evidence-driven, pin the corrected ARIEC61850 engine, prevent stale/unknown bindings from becoming false NoDataSet, detect verified source/live binding conflicts, disambiguate duplicate RCB names by logical scope, and add E016-style regression coverage.
This was referenced Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The RCB Export Filter could show
No DataSetwhen the DataSet binding was actually unresolved or when a newer live availability snapshot had stronger evidence than the stale discovery model. Duplicate short RCB names across Logical Devices also made different RCB instances look identical.Fix
DatSetread authoritative including an explicitly empty binding, so stale discovery cannot resurrect an old DataSet reference.datSetabsent, broken/unresolved reference, empty DataSet, and populated DataSet.DatSetread failed or was not attempted.urcbA01/brcbA01instances across Logical Devices are unambiguous.Engine dependency
masarray/ARIEC61850#53is merged. This branch is pinned to engine main commit239019e9a66513807d88354f5959ff7dbf280868, which requires positive live evidence before classifyingNoDataSetand hardens dynamic RCB slot selection.Validation
Safety invariant
Missing/unreadable evidence must never be presented as positive proof that a DataSet does not exist.