Skip to content

Fix RCB DataSet evidence merge and logical-scope display - #135

Merged
masarray merged 10 commits into
mainfrom
fix/rcb-dataset-evidence
Aug 12, 2026
Merged

masarray merged 10 commits into
mainfrom
fix/rcb-dataset-evidence

Conversation

@masarray

@masarray masarray commented Aug 12, 2026 •

Copy link
Copy Markdown
Owner

Problem

The RCB Export Filter could show No DataSet when the DataSet binding was actually unresolved or when a newer live availability snapshot had stronger evidence than the stale discovery model. Duplicate short RCB names across Logical Devices also made different RCB instances look identical.

Fix

  • Add a central RCB export evidence policy: unknown evidence stays unknown.
  • Make a successful live DatSet read authoritative including an explicitly empty binding, so stale discovery cannot resurrect an old DataSet reference.
  • Use live availability DataSet references ahead of stale discovery references when live evidence is positive.
  • Distinguish source SCL datSet absent, broken/unresolved reference, empty DataSet, and populated DataSet.
  • Detect source-SCL vs live-IED binding conflicts in all directions (different refs, source bound/live none, source none/live bound) and block export on verified conflict.
  • Do not create a false conflict when the live DatSet read failed or was not attempted.
  • Show logical scope below the short RCB name so duplicate urcbA01 / brcbA01 instances across Logical Devices are unambiguous.
  • Add E016-style synthetic regression tests without publishing the real CID/ICD fixture.

Engine dependency

masarray/ARIEC61850#53 is merged. This branch is pinned to engine main commit 239019e9a66513807d88354f5959ff7dbf280868, which requires positive live evidence before classifying NoDataSet and hardens dynamic RCB slot selection.

Validation

Safety invariant

Missing/unreadable evidence must never be presented as positive proof that a DataSet does not exist.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 12063be1fd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Services/RcbExportEvidencePolicy.cs
@masarray
masarray merged commit b64244f into main Aug 12, 2026
5 checks passed
masarray added a commit that referenced this pull request Aug 12, 2026
Make RCB DataSet detection evidence-driven, pin the corrected ARIEC61850 engine, prevent stale/unknown bindings from becoming false NoDataSet, detect verified source/live binding conflicts, disambiguate duplicate RCB names by logical scope, and add E016-style regression coverage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant