Skip to content

COMTRADE: smooth scrubbing across analysis workspaces - #318

Merged
masarray merged 6 commits into
mainfrom
ux/comtrade-smooth-scrub
Sep 16, 2026
Merged

masarray merged 6 commits into
mainfrom
ux/comtrade-smooth-scrub

Conversation

@masarray

@masarray masarray commented Sep 16, 2026 •

Copy link
Copy Markdown
Owner

Goal

Make COMTRADE interaction feel continuous, light and responsive across Time Signals, Phasor, Harmonics and Locus without adding input latency, native-analysis backlog, or presentation state that can override authoritative engineering values.

What changed

  • Time Signals: preserve the active P1D3 retained-mode hot path: synchronous cursor TranslateTransform updates and transform-only pan preview. Heavy waveform geometry is not rebuilt during normal scrub, so no artificial cursor lag is added.
  • Phasor: exact native vectors remain authoritative targets. Presentation vectors ease continuously on CompositionTarget.Rendering with frame-rate-independent shortest-angle interpolation, bounded settle time, then snap exactly to the native target.
  • Harmonics: exact native spectra remain authoritative targets. Prepared row buffers are reused; composition frames update numeric presentation state only, with bounded easing and exact final convergence.
  • Locus: native cursor calculation remains latest-only and one-worker-in-flight. R-X marker coordinates ease only in the transient presentation layer at composition cadence; static trajectories remain cached. PRI/SEC changes reset the presentation state first so values from different engineering bases are never interpolated together.
  • Frame pacing: presentation elapsed time is bounded so a temporary UI stall cannot create a giant jump; settle tolerance stops pumps once the exact target is reached.
  • Tests: regression coverage locks the composition-clock animation contract, reusable harmonic buffers, frame-time bounding and settle tolerance.

Performance / correctness contract

  • Pointer/cursor state remains immediate and authoritative.
  • No animation queue; latest target wins.
  • At most one native analysis worker per existing scheduler.
  • No extra native analysis solely for easing.
  • No periodic work after presentation settles.
  • First sample/topology changes snap instead of inventing motion from unrelated state.
  • COMTRADE engineering calculations and native ArdIrec authority are unchanged.

Gate

Merge only after the exact PR head passes application build/test, COMTRADE integration, installer/runtime smoke, and applicable evidence workflows.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 64b90928fb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ComtradeWorkspaceWindow.P1D4LiveScrub.cs Outdated
Comment thread ComtradeWorkspaceWindow.P1D5Locus.cs
@masarray
masarray merged commit cbd39e6 into main Sep 16, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant