refactor(sntp): neutral commissioning-profile names without wire change - #382
Merged
Merged
Conversation
…pecific product naming
…pecific product naming
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Remove external product branding from the ARSAS-owned SNTP default constant, packet test names, diagnostics and documentation. Rename
SntpServerProfile.CommissioningCompatibilityStratumto describe its actual role.Engineering boundary
The value stays 2. Mode 4/Mode 5,
LOCL, the clock-health unsynchronized response, VLAN/UDP framing and all active timing/control behavior remain untouched. Existing packet and Ethernet codec tests still assert the byte-level stratum and response semantics. The historical field observation and original device-specific attribution remain traceable via immutable source commite03ff1caa7d83902ef106f0c4aafdc3fb24143e5; this neutral label does not generalize the observation to all devices.Separate from convergence/SCL migration #381 and physical SCL issue #341. No engine or v1.6.40 release changes. Full CI before merge.