refactor(provenance): neutral IEC 61850 interoperability reference contract - #381
Conversation
…erical field authority
…nal comparison provenance
…ed physical acceptance
…hetic fixture copy
…hetic fixture copy
…f and immutable provenance
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 29963a92a6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Assert.Equal(30552, rejected.GetProperty("confirmedMmsRequests").GetInt32()); | ||
|
|
||
| var r10 = root.GetProperty("physicalEvidence").GetProperty("arsasR10"); | ||
| foreach (var edition in new[] { "edition1", "edition2" }) |
There was a problem hiding this comment.
When NeutralAuthority_PreservesOriginalPhysicalAcceptanceMetrics runs, GetProperty("edition1") throws because physicalEvidence.arsasR10 defines the nodes as reuseEdition1 and reuseEdition2. The test therefore fails before validating either edition; use the actual schema property names.
AGENTS.md reference: AGENTS.md:L174-L178
Useful? React with 👍 / 👎.
| Assert.Contains("docs/INTEROPERABILITY_REFERENCE_CONTRACT.md", source, StringComparison.Ordinal); | ||
| Assert.Contains("evidence/interoperability-reference-target.json", source, StringComparison.Ordinal); |
There was a problem hiding this comment.
When the ARSAS test suite runs, this test always fails because this commit removes both neutral document/evidence paths from $ApprovedConvergenceIdentifierPaths, leaving neither literal anywhere in verify-source-clean.ps1. Assert their intended absence instead, or restore them to the exemption list if they are still meant to be approved entries.
Useful? React with 👍 / 👎.
…a and narrowed exclusions
…a and narrowed exclusions
Why
The current-tree benchmark contract and CI filenames used the name of an unrelated proprietary comparison tool as an ARSAS product-internal identifier. The tool was a separately operated black-box reference, not a code dependency or a source for ARSAS implementation.
Scoped migration
36a4b87a3c2f6d34f73fa36c8a8a6a59763bd435, original evidence bloba853fd0ea115b320a648b1b2a52fe9a7f6af94cd. This does not imply the measurements came from another source.Evidence integrity
Programmatic before/after comparison of parsed JSON confirmed all 265 numeric and Boolean values remain identical and in the same order. The app/engine SHAs, report readiness, earlier failures and physical performance target remain present. No runtime code or release changes. Workflow/job names change deliberately; verify required check configuration (no branch protection/ruleset enabled as of initiation).
Merge gate
Full Windows CI, source-clean, new interoperability workflow, deterministic guards, and post-merge verification must pass on the combined source. Physical retest is not claimed for a name/schema-only migration. SCL corrective PR #374 stays separate and is not modified.