Conversation
This was referenced Sep 25, 2026
Owner
Author
|
Combined with #414 and #415 in draft integration PR #416 (#416). The 8-file combined candidate at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Start a bounded maintainability pass without changing the accepted v1.6.40 IEC 61850 behavior. Tracks #380.
Exact baseline and change scope
mainat9d081f54fc6466d13c099e8a94a020c487a36703.dc07b3f06fde71eb8f8370681f920850edd2eb8a.Services/UiResponsiveIec61850MonitorRuntimeFacade.cs: use the required non-nulldevice.DeviceIdin five UI-to-runtime calls, rather thandevice?.DeviceIdwhich unnecessarily marks the samedevicenullable at the delegated call.docs/README.md: link to canonicalVERSIONand published GitHub Release rather than maintaining a stale copy of the source version; repair two audit links to their actualdocs/audits/paths.CONTRIBUTING.md: point maintenance/refactoring contributions to the existingAGENTS.mdcontract; do not introduce another policy document.Preserved contracts
No change to Discovery, canonical model, SCL exporter, RCB selection, static DataSet report-only authority, GI, process polling, control lifecycle, engine locks, release pipeline, or published v1.6.40 assets. The five method signatures already declare
devicenon-null; there is no behavior change for valid calls. The contract for invalid null calls may now fail at argument access rather than later in the operation, so this is not represented as strict equivalence for unsupported inputs.Validation / review
VERSIONonmain.dc07b3f06fde71eb8f8370681f920850edd2eb8a, including Build ARSAS and Smart Discovery Field Capture Build. The Merge Execution Guard logged 1,315 passed, 0 failed, 0 skipped. The remainingCS8601warnings are two separate locations in trusted-SCL static reporting, outside this PR.Follow-up, not included
A separate ownership/dependency map and one-subsystem-at-a-time consolidation. Do not combine with open SCL parity PR #374.