Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 43893c6023
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| string.Equals(attribute.AttributePath, "stVal", StringComparison.Ordinal) && | ||
| string.Equals(attribute.FunctionalConstraint, "ST", StringComparison.Ordinal) && | ||
| string.Equals(attribute.TypeDiscoveryStatus, "Exact", StringComparison.Ordinal) && | ||
| attribute.TypeConfidence == LiveIedDiscoveryConfidenceLevel.Exact && | ||
| string.Equals(attribute.SclBType, "INT32", StringComparison.OrdinalIgnoreCase)) |
There was a problem hiding this comment.
When the attribute list contains one qualifying INT32 entry and another exact ST stVal entry declaring BOOLEAN or INT32U, this filter discards the contradictory entry, leaving exactIntegerStatus.Length == 1; the patch then rewrites the saved SCL to INS/INT32 despite ambiguous evidence. Collect all exact ST stVal candidates and require the sole candidate to be INT32 before applying the correction.
AGENTS.md reference: AGENTS.md:L60-L66
Useful? React with 👍 / 👎.
Root cause
The existing export-only compatibility correction for
MPLS_GGIO1.CBClsCounterrewrites the generated SCL to INS/INT32 based only on object identity, even for an exact Boolean or unknown type. This could misrepresent a different relay/firmware with the same name.Fix
ST stValattribute withTypeDiscoveryStatus=Exact,TypeConfidence=Exact, andSclBType=INT32from the pinned engine's live TypeSpecification-derived model.Release boundary
Post-release candidate only, not merged as v1.6.40 proof. No engine upgrade, discovery/RCB/reporting changes, new MMS reads, or modification of the published v1.6.40 binary. This is limited to export-time semantics and diagnostics.
Validation
CI is required, followed by a candidate-specific saved-SCL/reopen inspection on the physical reference before treating issue #341 as complete. v1.6.40 stays the accepted stable baseline throughout.