Default to ~/.config/gmailctl for newly created config dirs. - #455
Merged
Merged
Conversation
This was referenced Jun 17, 2026
lgarron
commented
Jun 17, 2026
mbrt
reviewed
Jun 17, 2026
Co-authored-by: Michele Bertasi <405934+mbrt@users.noreply.github.com>
mbrt
approved these changes
Jun 18, 2026
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #455 +/- ##
==========================================
- Coverage 37.60% 37.56% -0.05%
==========================================
Files 54 54
Lines 3670 3674 +4
==========================================
Hits 1380 1380
- Misses 2199 2203 +4
Partials 91 91 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mbrt
enabled auto-merge (squash)
June 19, 2026 06:24
mbrt
added a commit
that referenced
this pull request
Sep 26, 2026
Issue #463 reports that `gmailctl init` always uses ~/.gmailctl and ignores the XDG config directory. That was true in v0.12.0, the version it was tested with, but the XDG support landed afterwards in #455 and is not released yet. What remained wrong was the documentation, which made the location hard to guess: - The --config help text claimed the fallback is always $HOME/.config/gmailctl. - The README referred to `<XDG_BASE_DIR>`, which is not a variable defined by the XDG spec. The help text now prints the resolved path, computed the same way as the directory actually used, and the README names XDG_CONFIG_HOME, its per-platform defaults, and points to --help for the exact path. Close #463.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minimal fix for #144
It is a revision of #393 and uses a library for the internal XDG path calculation per feedback there.