Repository navigation
Conversation
Issue #463 reports that `gmailctl init` always uses ~/.gmailctl and ignores the XDG config directory. That was true in v0.12.0, the version it was tested with, but the XDG support landed afterwards in #455 and is not released yet. What remained wrong was the documentation, which made the location hard to guess: - The --config help text claimed the fallback is always $HOME/.config/gmailctl. - The README referred to `<XDG_BASE_DIR>`, which is not a variable defined by the XDG spec. The help text now prints the resolved path, computed the same way as the directory actually used, and the README names XDG_CONFIG_HOME, its per-platform defaults, and points to --help for the exact path. Close #463.
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #466 +/- ##
==========================================
- Coverage 39.23% 39.22% -0.02%
==========================================
Files 54 54
Lines 3680 3681 +1
==========================================
Hits 1444 1444
- Misses 2135 2136 +1
Partials 101 101 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #463 reports that
gmailctl initalways uses ~/.gmailctl and ignores the XDG config directory. That was true in v0.12.0, the version it was tested with, but the XDG support landed afterwards in #455 and is not released yet.What remained wrong was the documentation, which made the location hard to guess:
<XDG_BASE_DIR>, which is not a variable defined by the XDG spec.The help text now prints the resolved path, computed the same way as the directory actually used, and the README names XDG_CONFIG_HOME, its per-platform defaults, and points to --help for the exact path.
Close #463.