Fix Lidar DrawDebugPoints causing crash - #2614
Merged
Ratnesh Madaan (madratman) merged 1 commit intoApr 30, 2020
Merged
Conversation
Make the points non-persistent and reduce Lifetime
|
Tested and working. I approve |
Contributor
Author
|
Oren Bell (@nightduck) Great, thanks for testing! |
Contributor
Author
|
Another change which can be done is to make |
|
I would vote to keep them visible. For aesthetics, if not functionality. |
This was referenced Apr 30, 2020
Ratnesh Madaan (madratman)
pushed a commit
to ironclownfish/AirSim
that referenced
this pull request
May 2, 2020
Make the points non-persistent and reduce Lifetime
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the points non-persistent and reduce Lifetime
Issue: #2608
FYI Peter Hall (@IamPete1) Oren Bell (@nightduck)
Also see https://www.ue4community.wiki/Legacy/Draw_3D_Debug_Points,_Lines,_and_Spheres:_Visualize_Your_Algorithm_in_Action
For someone trying to reproduce-
FPS will drop to below 10, and the RAM usage will keep increasing, by about a GB in some 10-15 seconds
As to how it worked earlier, maybe the Persistency parameter was not working?
https://forums.unrealengine.com/development-discussion/c-gameplay-programming/1539369-drawdebughelpers-h-outdated-persistent-lines-not-working