Skip to content

Support initial silence timeout - #5400

Merged
William Wong (compulim) merged 7 commits into
mainfrom
bump-web-speech
Jan 7, 2025
Merged

Support initial silence timeout#5400
William Wong (compulim) merged 7 commits into
mainfrom
bump-web-speech

Conversation

@compulim

@compulim William Wong (compulim) commented Jan 7, 2025

Copy link
Copy Markdown
Collaborator

Fixes #4890.

Changelog Entry

Added

  • Added support for speech recognition initial silence timeout when using Azure Speech, in PR #5400, by @compulim

Changed

Description

Added support of initialSilenceTimeout options, which is added in web-speech-cognitive-services@8.1.0.

Specific Changes

  • Bumped to web-speech-cognitive-services@8.1.0
    • Added valibot to our transient dependencies
  • Passed initialSilenceTimeout to web-speech-cognitive-services
  • Added sample for configuring initial silence timeout
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@OEvgeny Eugene (OEvgeny) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any way to cover this with end-to-end tests using your test framework?

@compulim
William Wong (compulim) merged commit 5289ce3 into main Jan 7, 2025
@compulim
William Wong (compulim) deleted the bump-web-speech branch January 7, 2025 17:28
@tobiasvanderwerff

Copy link
Copy Markdown

William Wong (@compulim) Is it possible to add a parameter for EndSilenceTimeout as well? I.e. the length of time that a SpeechRecognizer detects silence (after recognition results have been generated) and assumes speech input has ended (https://learn.microsoft.com/en-us/windows/apps/design/input/set-speech-recognition-timeouts).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to set properties of SpeechConfig in createCognitiveServicesSpeechServicesPonyfillFactory ?

3 participants