Bump adaptivecards@3.0.5 - #5661
Merged
Merged
Conversation
William Wong (compulim)
marked this pull request as ready for review
December 19, 2025 19:09
Eugene (OEvgeny)
previously approved these changes
Dec 19, 2025
| Action, | ||
| ActionAlignment, | ||
| ActionButtonState, | ||
| // ActionButtonState, // Not in *.js because it is realized as a number, it is in *.d.ts though. |
Collaborator
There was a problem hiding this comment.
I guess we leverage their types
Collaborator
Author
There was a problem hiding this comment.
It's enum. And the *.js expanded the enum back to number. So the *.js never know about ActionButtonState and not using it at all.
So it's technically importable as type, but not runnable I guess.
I am keeping it here for sake for clarity why we are not exporting it.
Eugene (OEvgeny)
approved these changes
Dec 19, 2025
Merged
11 tasks
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Changed
adaptivecards@3.0.5Description
Bump Adaptive Cards to 3.0.5.
Design
Checkbox group container no longer have tab index
There is an old accessibility bug (since
adaptivecards@2.11) related to checkbox group container. The container itself hastabindex="0". For compliance, it should not.We updated our test code to reflect their update.
Specific Changes
npm install adaptivecards@3.0.5underbundleandrepack/adaptive-cardsnpm dedupeto reducepackage-lock.jsonsizeadaptivecardspackage is installed at/packages/bundle/node_modulesand/packages/repack/adaptive-cards/node_modulesseparately, running dedupe will reunite them at/node_modules/package.json/workspacesto remove./prefixnpm init --workspace ...does not add./prefixI have added tests and executed them locallyCHANGELOG.mdI have updated documentationReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)Tests reviewed (coverage, legitimacy)