Remove Resurrect logic as it shouldn't be needed for .NET 6 and newer. - #1380
Merged
Manodasan Wignarajah (manodasanW) merged 3 commits intoJan 25, 2024
Conversation
Johan Laanstra (jlaanstra)
marked this pull request as ready for review
November 11, 2023 04:50
Johan Laanstra (jlaanstra)
requested a review
from Manodasan Wignarajah (manodasanW)
November 30, 2023 22:35
Johan Laanstra (jlaanstra)
force-pushed
the
user/jlaans/remove-resurrect
branch
from
January 2, 2024 17:21
d5b7249 to
9d04677
Compare
Sergio Pedri (Sergio0694)
requested changes
Jan 8, 2024
Sergio Pedri (Sergio0694)
force-pushed
the
user/jlaans/remove-resurrect
branch
from
January 20, 2024 18:48
cc32b1e to
7c9fe67
Compare
Johan Laanstra (jlaanstra)
force-pushed
the
user/jlaans/remove-resurrect
branch
from
January 25, 2024 03:19
7c9fe67 to
52a3feb
Compare
Member
|
Confirmed using both .NET 6 and .NET 8 with the old repro app that this change runs without issue. |
Manodasan Wignarajah (manodasanW)
approved these changes
Jan 25, 2024
Sergio Pedri (Sergio0694)
pushed a commit
that referenced
this pull request
Jan 25, 2024
#1380) * Remove Resurrect logic as it shouldn't be needed for .NET 6 and newer. * Remove double check. * Add check back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After talking with Manodasan Wignarajah (@manodasanW) we should no longer need Resurrect on .NET 6 and newer.