Remove object field and allocation from ObjectReference - #1458
Merged
Sergio Pedri (Sergio0694) merged 3 commits intoJan 26, 2024
Merged
Sergio Pedri (Sergio0694) merged 3 commits into
Sergio Pedri (Sergio0694) merged 3 commits into
Conversation
Sergio Pedri (Sergio0694)
requested review from
Johan Laanstra (jlaanstra) and
Manodasan Wignarajah (manodasanW)
January 20, 2024 18:50
Johan Laanstra (jlaanstra)
approved these changes
Jan 25, 2024
Sergio Pedri (Sergio0694)
force-pushed
the
user/sergiopedri/smaller-objectreference
branch
from
January 26, 2024 03:11
df397e5 to
7b2669c
Compare
Sergio Pedri (Sergio0694)
marked this pull request as ready for review
January 26, 2024 03:11
Manodasan Wignarajah (manodasanW)
approved these changes
Jan 26, 2024
Sergio Pedri (Sergio0694)
deleted the
user/sergiopedri/smaller-objectreference
branch
January 26, 2024 14:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimization to ObjectReference to basically drop one object per WinRT object every time.
Detailed explanation in the comments added in this PR.
Based on top of #1380, needs that one first (so draft for now).