Update DIA to latest - #58
Merged
Merged
Conversation
Michael Niksa (miniksa)
approved these changes
Jul 13, 2026
Jon Wiswall (jonwis)
added a commit
to jonwis/SizeBench
that referenced
this pull request
Jul 14, 2026
Brings PR microsoft#56 up to date with main (microsoft#55, microsoft#57, microsoft#58 incl. the DIA update and net8->net10 upgrade). Conflict resolutions: - DIAAdapter: keep the loadFromSource delegate (symbol-server path) but route the PDB path through main's new prefetching loadDataFromPdbEx on IDiaDataSourceEx2. - msdia140.dll: keep main's updated checked-in binary (needed for IDiaDataSourceEx2) and layer PR microsoft#56's symsrv.dll drop on top for symbol-server support. - Directory.Packages.props / GUI.csproj: union of both sides, newer versions win. - IDE0031: use C# 14 null-conditional assignment for _appSettings?.UseSymbolServer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this change being made?
DIA has a lot of new features since SizeBench last took an update - for example it has prefetching capabilities that may improve perf, and it has support for MSFZ compressed PDBs.
Picking this up enables SizeBench to read newer PDBs.
Briefly summarize what changed
_Atomicso added support for parsing such type names, and I noticed we lacked__restrictnearby, so doing both at once.E_PDB_CORRUPTin more places which triggers in the SizeBench test suite because we have PDBs generated with symbols from older versions of MASM. So, we tolerate more cases in determining whenE_PDB_CORRUPTcan be worked around, so the test suite continues to pass.How was the change tested?
Currently relying on existing test suite. It would be ideal to add some tests for
_Atomicand__restrictbut for purposes of time invested, I'm skipping that ideal world for now.PR Checklist