fix(aria): annotate aria-hidden elements in AI snapshots - #42268
Merged
Dmitry Gozman (dgozman) merged 1 commit intoAug 20, 2026
Merged
Conversation
|
|
||
| const childAriaNode = visible ? toAriaNode(element, options, nameSourceElements) : null; | ||
| if (childAriaNode && !isElementVisibleForAria) | ||
| childAriaNode.props['aria-hidden'] = 'true'; |
There was a problem hiding this comment.
It annotates every node in a hidden subtree, not just the boundary. This will bloat snapshots in the scenario like the one in the issue.
Collaborator
There was a problem hiding this comment.
+1. Let's also add a test that covers this, to make sure we only annotate the top element in the hidden subtree.
Contributor
Author
There was a problem hiding this comment.
Fixed, checks the element's own attribute now.
Contributor
Author
There was a problem hiding this comment.
Let's also add a test that covers this, to make sure we only annotate the top element in the hidden subtree.
added
|
|
||
| // AI snapshot includes aria-hidden elements but annotates them. | ||
| const aiSnapshot = await snapshotForAI(page); | ||
| expect(aiSnapshot).toContain('[aria-hidden]'); |
Collaborator
There was a problem hiding this comment.
Please assert the exact snapshot with toContainYaml like other tests here.
Contributor
Author
There was a problem hiding this comment.
Done.
|
|
||
| const childAriaNode = visible ? toAriaNode(element, options, nameSourceElements) : null; | ||
| if (childAriaNode && !isElementVisibleForAria) | ||
| childAriaNode.props['aria-hidden'] = 'true'; |
Collaborator
There was a problem hiding this comment.
+1. Let's also add a test that covers this, to make sure we only annotate the top element in the hidden subtree.
Aditya Kumar Gupta (triemerge)
force-pushed
the
fix/aria-hidden-annotation
branch
from
August 19, 2026 21:43
368b5c1 to
3d0036b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Aditya Kumar Gupta (triemerge)
force-pushed
the
fix/aria-hidden-annotation
branch
from
August 20, 2026 07:41
3d0036b to
e29f979
Compare
Aditya Kumar Gupta (triemerge)
requested review from
Dmitry Gozman (dgozman) and
Yury Semikhatsky (yury-s)
August 20, 2026 07:43
Contributor
Test results for "tests 1"21 flaky51215 passed, 1233 skipped Merge workflow run. |
Contributor
Test results for "MCP"3 failed 8120 passed, 1341 skipped Merge workflow run. |
Dmitry Gozman (dgozman)
approved these changes
Aug 20, 2026
Dmitry Gozman (dgozman)
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me, thank you.
Dmitry Gozman (dgozman)
merged commit Aug 20, 2026
4126cf5
into
microsoft:main
43 of 45 checks passed
This was referenced Aug 20, 2026
This was referenced Aug 22, 2026
Merged
12 tasks
This was referenced Sep 17, 2026
This was referenced Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
The AI-mode snapshot (
mode: "ai") intentionally includesaria-hiddenelements because they are visually visible, but nothing distinguishes them from ARIA-visible content. When a test fails anderror-context.mdis generated, agents (and humans) see content thatgetByRoleandariaSnapshot()will never find, with no indication why.This adds an
[aria-hidden]annotation following the same bracket pattern as[checked],[disabled],[expanded]etc. Elements included only through visual visibility (not ARIA visibility) now render with[aria-hidden]in the key. Default-mode snapshots are completely unaffected since they exclude these elements entirely.Fixes #42223