fix(webkit): use native checkVisibility for element visibility - #42971
Merged
Yury Semikhatsky (yury-s) merged 3 commits intoSep 28, 2026
Merged
Conversation
WebKit's checkVisibility now handles closed details and unslotted content, so the manual workaround is only kept for browsers without it. This fixes content of a details nested in a closed details being reported as visible in WebKit.
Drop the manual details/summary fallback for browsers without checkVisibility. Minimum supported versions are now Electron 21 and Chrome 105 on Android.
Pavel Feldman (pavelfeldman)
approved these changes
Sep 28, 2026
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
|
Hi, I'm the Playwright bot and I took a first look at the CI failures. 🔴 One failure looks caused by this PR
DetailsChecked against head Caused by this PR
Pre-existing flake / infra
Uncertain
Triaged by the Playwright bot - agent run |
WebKit does not create renderers for options in a list box, so checkVisibility() returns false for them.
Contributor
Test results for "tests 1"5 flaky52331 passed, 1243 skipped Merge workflow run. |
Contributor
Test results for "MCP"8790 passed, 1480 skipped Merge workflow run. |
This was referenced Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Element.checkVisibility()in WebKit too; the WebKit bug that required the manual fallback is fixed for<details>and unslotted content.<details>nested inside a closed<details>being reported as visible in WebKit.checkVisibility(); minimum supported versions are now Electron 21 and Chrome 105 on Android.Supersedes #42951.