chore(build): set esbuild target to node20 - #42657
Conversation
esbuild had no explicit target and defaulted to esnext, so `using` declarations reached lib/ verbatim and failed to parse on the minimum supported node. Adds Symbol.dispose to JSHandle and uses it for the frame element handle in crPage.
| if (frame === this._page.mainFrame()) | ||
| return { x: 0, y: 0 }; | ||
| const element = await frame.frameElement(nullProgress); | ||
| using element = await frame.frameElement(nullProgress); |
There was a problem hiding this comment.
do you think we should as part of this go through and change the other manual finally { foo.dispose(); } (e.g. _retryWithProgressIfNotConnected, waitForFunctionExpression, etc.)?
or would you rather have that be a followup (or just when that code is next modified)?
There was a problem hiding this comment.
I included this one instance as a test that it works and that the tests pass.
Test results for "MCP"1 failed 8347 passed, 1376 skipped Merge workflow run. |
Test results for "tests 1"3 flaky51545 passed, 1247 skipped Merge workflow run. |
|
Hi, I'm the Playwright bot and I took a first look at the CI failures here. 🟢 The one failure is a pre-existing flake — this PR is clearThe single red — DetailsOverall: Pre-existing flake / infra
Triaged by the Playwright bot - agent run |
efb0761
into
microsoft:main
Summary
esnext, sousingdeclarations reachedlib/verbatim and failed to parse on the minimum supported node.Symbol.disposetoJSHandleand uses it for the frame element handle incrPage.