Skip to content

chore(build): set esbuild target to node20 #42657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pavel Feldman (pavelfeldman) merged 1 commit into from
Sep 10, 2026
Merged

chore(build): set esbuild target to node20 #42657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/playwright-core/src/server/chromium/crPage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1145,7 +1145,7 @@ class FrameSession {
return null;
if (frame === this._page.mainFrame())
return { x: 0, y: 0 };
const element = await frame.frameElement(nullProgress);
using element = await frame.frameElement(nullProgress);

@dcrousso Devin Rousso (dcrousso) Sep 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you think we should as part of this go through and change the other manual finally { foo.dispose(); } (e.g. _retryWithProgressIfNotConnected, waitForFunctionExpression, etc.)?

or would you rather have that be a followup (or just when that code is next modified)?

@pavelfeldman Pavel Feldman (pavelfeldman) Sep 10, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I included this one instance as a test that it works and that the tests pass.

const box = await element.boundingBox(nullProgress);
return box;
}
Expand Down
4 changes: 4 additions & 0 deletions packages/playwright-core/src/server/javascript.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,10 @@ export class JSHandle<T = any> extends SdkObject {
}
}

[Symbol.dispose]() {
this.dispose();
}

override toString(): string {
return this._preview;
}
Expand Down
1 change: 1 addition & 0 deletions utils/build/build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,6 +331,7 @@ class EsbuildStep extends Step {
sourcemap: withSourceMaps ? 'linked' : false,
platform: 'node',
format: 'cjs',
target: 'node20',
...options,
};
this._watchPaths = watchPaths;
Expand Down
Loading