fix(chromium): report numpad location on keyup - #42913
Merged
Yury Semikhatsky (yury-s) merged 1 commit intoSep 25, 2026
Merged
Yury Semikhatsky (yury-s) merged 1 commit into
Yury Semikhatsky (yury-s) merged 1 commit into
Conversation
keyUp was dispatched without isKeypad, so Chromium reported numpad keys with location LEFT on keyup, while keydown had NUMPAD. Firefox and WebKit already report NUMPAD for both.
Yury Semikhatsky (yury-s)
approved these changes
Sep 24, 2026
Member
|
Yuriy Mikityuk (@yuriy-mikityuk) please accept CLA as described above so that we could merge this pr |
Contributor
Test results for "tests 1"5 flaky52281 passed, 1241 skipped Merge workflow run. |
Contributor
Test results for "MCP"2 failed 8710 passed, 1480 skipped Merge workflow run. |
Contributor
Author
|
@microsoft-github-policy-service agree |
This was referenced Sep 25, 2026
Yury Semikhatsky (yury-s)
merged commit Sep 25, 2026
6b37d04
into
microsoft:main
43 of 45 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
keyUp in crInput.ts was sent without isKeypad, so in Chromium press('NumpadSubtract') gave keydown with location 3 (NUMPAD) but keyup with location 1 (LEFT). Firefox and WebKit report 3 for both. The existing location test only checks keydown, so I added one that checks keyup too.