chore(bidi): scale screencast frames in the browser - #42926
Conversation
ed4e1bc to
d6e3fc2
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"5 flaky52279 passed, 1255 skipped Merge workflow run. |
Test results for "MCP"1 failed 8750 passed, 1480 skipped Merge workflow run. |
|
Hi, I'm the Playwright bot and I took a first look at the CI failures here. 🟢 The one failure is a pre-existing flake
DetailsThe only failing test in the latest report is an MCP test on Pre-existing flake / infra
Triaged by the Playwright bot - agent run |
3e79a31
into
microsoft:main
Fixes "screencast.start delivers frames via onFrame callback" in
library/screencast.spec.ts.Note that this PR regresses the test "onFrame receives viewport size" in the same file: the
onFramecallback receives the scaled image's dimensions instead of the viewport dimensions. But I think it's worth making this change anyway for the performance improvement of not sending unscaled images over the protocol.In the long run we want to move away from using
browsingContext.captureScreenshotfor screencasts (see w3c/webdriver-bidi#1134), we'll make sure that this will also include the viewport dimensions.