Repository navigation
fix(webkit): hide content of a details nested in a closed details - #42951
Closed
Yuriy Mikityuk (yuriy-mikityuk) wants to merge 1 commit into
Closed
Yuriy Mikityuk (yuriy-mikityuk) wants to merge 1 commit into
Yuriy Mikityuk (yuriy-mikityuk) wants to merge 1 commit into
Conversation
WebKit doesn't use checkVisibility(), so visibility falls back to a manual check for details. It only looked at the closest details or summary, so an open details inside a closed one was reported as visible together with everything in it. Check all ancestors instead.
Collaborator
|
Closing in favor of #42971. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In WebKit, elements inside an open details that is nested in a closed one were treated as visible:
The button isn't rendered, but in WebKit
locator('button').isVisible()returned true,getByRole('button')found it and the aria snapshot included it. Chromium and Firefox usecheckVisibility()and get it right.The WebKit fallback only checked the closest details or summary. Now it checks all ancestors. I ran into this while comparing aria snapshots of generated pages across the three engines.
Fixes #43018