Skip to content

feat(webkit): roll to r2369 - #42991

Merged
Dmitry Gozman (dgozman) merged 1 commit into
mainfrom
roll-into-pw-webkit/2369
Sep 30, 2026
Merged

Dmitry Gozman (dgozman) merged 1 commit into
mainfrom
roll-into-pw-webkit/2369

Conversation

@microsoft-playwright-automation

Copy link
Copy Markdown
Contributor

Browser build: https://github.com/microsoft/playwright-browsers/commit/79b31569b809e799e639f2fe53fd032e01a1217d. Build has full platform coverage - check that all tests pass there.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

5 flaky ⚠️ [chromium-library] › library/video.spec.ts:762 › screencast › should work with video+trace `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/popup.spec.ts:260 › should not throw when click closes popup `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:213 › should intercept service worker requests (main and within) `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-ubuntu-22.04-node20`

52383 passed, 1243 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

8829 passed, 1480 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 2"

3 failed
❌ [firefox-library] › library/inspector/cli-codegen-aria.spec.ts:87 › should update aria snapshot highlight @firefox-macos-15-large
❌ [android-page] › page/locator-is-visible.spec.ts:93 › isVisible and isHidden should work with list box options
❌ [android-page] › page/page-set-content.spec.ts:57 › should include shadow roots

24 flaky ⚠️ [chromium-library] › library/chromium/chromium.spec.ts:436 › should produce network events, routing, and annotations for Service Worker (advanced) `@tracing-chromium`
⚠️ [chromium-library] › library/beforeunload.spec.ts:130 › should support dismissing the dialog multiple times `@chrome-ubuntu-22.04`
⚠️ [chromium-library] › library/chromium/oopif.spec.ts:179 › should take screenshot `@chromium-macos-14-xlarge`
⚠️ [chromium-library] › library/chromium/oopif.spec.ts:179 › should take screenshot `@chromium-macos-15-xlarge`
⚠️ [chromium-library] › library/selector-generator.spec.ts:574 › selector generator › should ignore empty data-test-id for candidate consideration `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:617 › selector generator › should generate exact title when necessary `@chrome-macos-latest`
⚠️ [chromium-library] › library/selectors-register.spec.ts:76 › should work when registered on global `@chrome-macos-latest`
⚠️ [chromium-page] › page/workers.spec.ts:191 › should attribute network activity for worker inside iframe to the iframe `@chrome-macos-latest`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@tracing-firefox`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@tracing-firefox`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-macos-15-large`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-macos-15-large`
⚠️ [firefox-library] › library/browsercontext-viewport.spec.ts:154 › should set both screen and viewport options `@firefox-macos-15-large`
⚠️ [firefox-library] › library/inspector/cli-codegen-csharp.spec.ts:202 › should not print context options method override in nunit if no options were passed `@firefox-macos-15-large`
⚠️ [firefox-library] › library/inspector/cli-codegen-pytest.spec.ts:49 › should save the codegen output to a file if specified `@firefox-macos-15-large`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-windows-latest`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-windows-latest`
⚠️ [firefox-library] › library/proxy.spec.ts:404 › should use http proxy for websocket requests `@firefox-windows-latest`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-macos-15-xlarge`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-macos-15-xlarge`
⚠️ [webkit-page] › page/page-autowaiting-basic.spec.ts:58 › should await form-get on click `@tracing-webkit`
⚠️ [webkit-library] › library/tracing.spec.ts:533 › should produce screencast frames fit `@webkit-macos-15-xlarge`
⚠️ [webkit-library] › library/browsertype-connect.spec.ts:813 › launchServer › should upload a folder `@webkit-macos-15-large`
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1934 › should not leak recorders `@webkit-macos-15-large`

112663 passed, 4784 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot and I looked at the CI failures on this PR.

🟡 Probably not caused by this PR, but one failure is unconfirmed

This PR only changes the WebKit entry in packages/playwright-core/browsers.json. None of the 3 failures run on WebKit. Two of them already fail on main. The third is a test added yesterday that the database has no history for, so I can't confirm it's a known failure.

Details

None of the three failing tests use WebKit: one runs on Firefox and two on Android, which drives Chrome on a device. So the WebKit change here can't reach any of them. The 24 flaky tests also look unrelated: the few WebKit ones passed on retry.

Pre-existing flake / infra

  • [firefox-library] › library/inspector/cli-codegen-aria.spec.ts:87 › should update aria snapshot highlight (firefox-macos-15-large): a known flake. The test-results database has it failing in 17 of 959 runs, 16 of them on main, and passing on retry in 44 more.
  • [android-page] › page/page-set-content.spec.ts:57 › should include shadow roots: already broken on Android. It failed in all 46 runs in the database, 43 of them on main.

Uncertain

  • [android-page] › page/locator-is-visible.spec.ts:93 › isVisible and isHidden should work with list box options: this test was added in fix(webkit): use native checkVisibility for element visibility #42971 (merged 2026-09-28). That PR also changed visibility detection in packages/injected/src/domUtils.ts and roleUtils.ts. The database has no runs of it yet, so I couldn't find it failing anywhere else. This PR doesn't touch the injected scripts or anything Android runs, so the most likely cause is that the new test fails on Android. That would be true on main too, and the fix would be an Android skip or a follow-up to fix(webkit): use native checkVisibility for element visibility #42971, not a change here. To confirm, check whether the test fails in the next main run that includes Android.

Note: the database refresh failed with a GitHub API 500, so these numbers come from the latest snapshot and may miss the last few hours of runs.

Triaged by the Playwright bot - agent run

@dgozman
Dmitry Gozman (dgozman) merged commit ee59489 into main Sep 30, 2026
73 of 75 checks passed
@dgozman
Dmitry Gozman (dgozman) deleted the roll-into-pw-webkit/2369 branch September 30, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant