Skip to content

test: add fixme test for binding called from pagehide in chromium - #43073

Merged
Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom
dgozman:test-43064
Oct 2, 2026
Merged

Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom
dgozman:test-43064

Conversation

@dgozman

Copy link
Copy Markdown
Collaborator

Summary

  • Adds a test that calls an exposed binding from a pagehide handler while navigating away. Passes in Firefox and WebKit.
  • Marked fixme in Chromium: with RenderDocument, the navigation swaps the frame host and Chromium never sends Runtime.bindingCalled (nor Runtime.consoleAPICalled) for the old document's pagehide/visibilitychange/unload handlers.

References #43064

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

7 flaky ⚠️ [chromium-library] › library/browsercontext-page-event.spec.ts:173 › should work with Ctrl-clicking `@frozen-time-library-chromium-linux`
⚠️ [chromium-library] › library/browsercontext-page-event.spec.ts:173 › should work with Ctrl-clicking `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/video.spec.ts:762 › screencast › should work with video+trace `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/browsercontext-page-event.spec.ts:160 › should work with Shift-clicking `@realtime-time-library-chromium-linux`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:213 › should intercept service worker requests (main and within) `@chromium-ubuntu-22.04-node24`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-ubuntu-22.04-node20`

52538 passed, 1276 skipped


Merge workflow run.

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Test results for "MCP"

3 failed
❌ [firefox] › mcp/cli-core.spec.ts:57 › click link @mcp-windows-latest-firefox
❌ [firefox] › mcp/cli-drag.spec.ts:53 › drop files and data onto an element @mcp-windows-latest-firefox
❌ [webkit] › mcp/http.spec.ts:92 › http transport browser lifecycle (isolated) @mcp-ubuntu-latest-webkit

8934 passed, 1489 skipped


Merge workflow run.

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot and I took a first look at the CI failures.

🟢 All three failures are confirmed pre-existing flakes — this PR is clear

This PR only adds a library test for an exposed binding during pagehide; it does not touch MCP code. Each failing MCP test has failed with the same project and bot on unrelated changes.

Details

Overall: the "tests 1" report has no real failures; its seven flaky tests passed on retry. The MCP report has three failures, all in code paths outside this one-file test-only diff.

Pre-existing flake / infra

The added browsercontext-expose-function.spec.ts case runs in the library workflow and cannot affect these separate MCP jobs.

Triaged by the Playwright bot - agent run

@dgozman
Dmitry Gozman (dgozman) merged commit ca64f9f into microsoft:main Oct 2, 2026
43 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants