This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Allow Language Server to work with .NET 5.0. Detect absence of .NET SDK 3.1 or greater and display error message#796
Closed
vxfield wants to merge 12 commits into
Closed
Allow Language Server to work with .NET 5.0. Detect absence of .NET SDK 3.1 or greater and display error message#796vxfield wants to merge 12 commits into
vxfield wants to merge 12 commits into
Conversation
bamarsha
suggested changes
Jan 11, 2021
…ft/qsharp-compiler into xfield/build-locator-fix
bamarsha
reviewed
Jan 19, 2021
| <PackageReference Include="Newtonsoft.Json" Version="12.0.2" /> | ||
| <PackageReference Include="StreamJsonRpc" Version="2.2.34" /> | ||
| <PackageReference Include="System.Reactive" Version="4.2.0" /> | ||
| <PackageReference Include="NuGet.Frameworks" Version="5.8.0" /> |
Contributor
There was a problem hiding this comment.
It worries me a little that it's necessary to include this dependency, since we had issues with depending on a specific version of NuGet.ProjectModel before. @bettinaheim @ricardo-espinoza
Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com>
Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com>
Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com>
Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com>
Contributor
|
Updating the language server to .NET 5 is blocked until the QDK build pipeline can be updated. I don't know when that will be, so I'll close this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR mitigates issue #737 by using the latest MS Build Locator package (fix).
It picks some changes from the November QDK release fix #755 with: