Allows setting WinGet proxy setting as SFS Client Proxy - #5032
Closed
nidietr-MSFT wants to merge 10 commits into
Closed
Allows setting WinGet proxy setting as SFS Client Proxy#5032nidietr-MSFT wants to merge 10 commits into
nidietr-MSFT wants to merge 10 commits into
Conversation
Requires ingesting sfs-client update from microsoft/sfs-client#218
Requires ingesting sfs-client update including microsoft/sfs-client#218
florelis
reviewed
Dec 2, 2024
florelis
left a comment
Member
There was a problem hiding this comment.
Looks good to me. Before merging we'll have to update the sfs subtree in src/SfsClient (instructions in the README in that location)
nidietr-MSFT
force-pushed
the
WinGetDownloadProxySupport
branch
from
December 6, 2024 18:39
ebb149d to
5426ef4
Compare
Contributor
Author
|
@microsoft-github-policy-service agree company="Microsoft"
|
yao-msft
reviewed
Dec 9, 2024
0e27525d Bumping version to 1.1.0 (microsoft#222) c639a506 Adding support for a custom proxy input (microsoft#218) 258d189b Improve logging when the content type is wrong (microsoft#221) 216210ab Adding required permissions to enable uploading of CodeQL results (microsoft#214) fb953d6e Bump github/codeql-action from 2 to 3 (microsoft#215) 52af7124 Enabling CodeQL scanning (microsoft#211) e555d764 Bump clang-format from 18.1.5 to 19.1.1 (microsoft#210) ab8f0e72 Setup: improving build tools installation (microsoft#207) git-subtree-dir: src/SfsClient/sfs-client git-subtree-split: 0e27525d597c730e71646fd0b15bdc8c8503f24d
…t-Update1.1.0-ForProxySupport
2 tasks
JohnMcPMS
added a commit
that referenced
this pull request
Dec 10, 2024
Pulling SfsClient subtree release 1.1.0 [SfsClient Release 1.1.0](https://github.com/microsoft/sfs-client/releases/tag/1.1.0) Which brought especially [SfsClient - Client: proxy support #84](microsoft/sfs-client#218) This subtree update is required for WinGet Download Proxy support [WinGet download doesn't work through a proxy #5030](#5030) Also requires passing the appropriate proxy to SfsClient which is done as part of separate PR [Allows setting WinGet proxy setting as SFS Client Proxy #5032](#5032)
Member
|
I've merged the SfsClient update PR; please remove the SfsClient update from this PR and we can run a build. |
2 tasks
Contributor
Author
|
Closing this PR to have a clean change in |
JohnMcPMS
pushed a commit
that referenced
this pull request
Dec 11, 2024
Allows setting WinGet proxy setting as the SFS Client Proxy. Fixes the issue below [WinGet download doesn't work through a proxy #5030](#5030) This PR requires SfsClient subtree updated to 1.1.0 [SfsClient update 1.1.0 for proxy support #5052](#5052) Which brings especially [Adding support for a custom proxy input #218](microsoft/sfs-client#218) This PR replaces closed PR below [Allows setting WinGet proxy setting as SFS Client Proxy #5032](#5032) <!-- To check a checkbox place an "x" between the brackets. e.g: [x] --> - [x] I have signed the [Contributor License Agreement](https://cla.opensource.microsoft.com/microsoft/winget-pkgs). - [x] This pull request is related to an issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows setting WinGet proxy setting as the SFS Client Proxy.
Fixes the issue below
WinGet download doesn't work through a proxy #5030
This PR requires ingesting Sfs-client update with
microsoft/sfs-client#218
Microsoft Reviewers: Open in CodeFlow