Improve search results output - #84
Merged
Merged
Conversation
…han the maximum allowed to be returned
Contributor
|
By the way, does Kevin still want table output for show command? |
Member
Author
|
I think for show we won't, except maybe for the versions, but even then it would just be for consistency. In reply to: 613121674 [](ancestors = 613121674) |
JohnMcPMS
added a commit
that referenced
this pull request
Dec 10, 2024
Pulling SfsClient subtree release 1.1.0 [SfsClient Release 1.1.0](https://github.com/microsoft/sfs-client/releases/tag/1.1.0) Which brought especially [SfsClient - Client: proxy support #84](microsoft/sfs-client#218) This subtree update is required for WinGet Download Proxy support [WinGet download doesn't work through a proxy #5030](#5030) Also requires passing the appropriate proxy to SfsClient which is done as part of separate PR [Allows setting WinGet proxy setting as SFS Client Proxy #5032](#5032)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
This change adds a bool output to the SearchResults that indicates whether the results were truncated. In addition, the results are now formatted as a table.
Testing
Tests are added for truncated search results.